RE: doc: pgevent.dll location

2024-11-29 Thread Ryohei Takahashi (Fujitsu)
Hi, Thank you for your commit. Regards, Ryohei Takahashi

Re: doc: pgevent.dll location

2024-11-26 Thread Peter Eisentraut
On 15.11.24 14:53, Ryohei Takahashi (Fujitsu) wrote: Thank you for your patch. The patch worked in my Windows build environment and pgevent.dll is installed to lib/ directory. Thanks for checking. I have committed this patch and backpatched it to PG16 and PG17. So the next minor releases wi

RE: doc: pgevent.dll location

2024-11-15 Thread Ryohei Takahashi (Fujitsu)
Hi, Thank you for your patch. The patch worked in my Windows build environment and pgevent.dll is installed to lib/ directory. Regards, Ryohei Takahashi

Re: doc: pgevent.dll location

2024-11-13 Thread Peter Eisentraut
On 12.11.24 17:52, Peter Eisentraut wrote: So the most straightforward way to "make it work like it used to" would be to change src/bin/pgevent/meson.build to use shared_module() instead of shared_library(). I developed the attached patch for this. I haven't tested it locally, but I checked i

Re: doc: pgevent.dll location

2024-11-12 Thread Andres Freund
Hi, On 2024-11-12 16:11:44 -0500, Robert Haas wrote: > On Tue, Nov 12, 2024 at 3:06 PM Peter Eisentraut wrote: > > In this context, a shared module is something like plpgsql or hstore > > that you dlopen, and a shared library is something like libpq or libecpg > > that you -l at build time. > > T

Re: doc: pgevent.dll location

2024-11-12 Thread Robert Haas
On Tue, Nov 12, 2024 at 3:06 PM Peter Eisentraut wrote: > On 12.11.24 18:27, Robert Haas wrote: > > On Tue, Nov 12, 2024 at 11:52 AM Peter Eisentraut > > wrote: > >> So the most straightforward way to "make it work like it used to" would > >> be to change src/bin/pgevent/meson.build to use share

Re: doc: pgevent.dll location

2024-11-12 Thread Peter Eisentraut
On 12.11.24 18:27, Robert Haas wrote: On Tue, Nov 12, 2024 at 11:52 AM Peter Eisentraut wrote: So the most straightforward way to "make it work like it used to" would be to change src/bin/pgevent/meson.build to use shared_module() instead of shared_library(). Based on the explanation in the do

Re: doc: pgevent.dll location

2024-11-12 Thread Robert Haas
On Tue, Nov 12, 2024 at 11:52 AM Peter Eisentraut wrote: > So the most straightforward way to "make it work like it used to" would > be to change src/bin/pgevent/meson.build to use shared_module() instead > of shared_library(). > > Based on the explanation in the documentation, this file is really

Re: doc: pgevent.dll location

2024-11-12 Thread Peter Eisentraut
On 12.11.24 17:02, Robert Haas wrote: On Wed, Nov 6, 2024 at 11:11 AM Peter Eisentraut wrote: I don't have Windows handy to test it out, but looking at the respective build system source files, in master, pgevent is built and installed like a normal shared library in both meson.build and Makefi

Re: doc: pgevent.dll location

2024-11-12 Thread Robert Haas
On Wed, Nov 6, 2024 at 11:11 AM Peter Eisentraut wrote: > I don't have Windows handy to test it out, but looking at the respective > build system source files, in master, pgevent is built and installed > like a normal shared library in both meson.build and Makefile, so it > should end up somewhere

Re: doc: pgevent.dll location

2024-11-11 Thread Amit Kapila
On Thu, Nov 7, 2024 at 1:46 PM Dave Page wrote: > > Hi > > On Wed, 6 Nov 2024 at 16:11, Peter Eisentraut wrote: >> >> On 06.11.24 13:57, Ryohei Takahashi (Fujitsu) wrote: >> > The dll install paths are changed as follows on Windows. >> > >> > (1) pgevent.dll >> > PG16: lib/ >> > PG17: bin/ >> > >

Re: doc: pgevent.dll location

2024-11-07 Thread Dave Page
Hi On Wed, 6 Nov 2024 at 16:11, Peter Eisentraut wrote: > On 06.11.24 13:57, Ryohei Takahashi (Fujitsu) wrote: > > The dll install paths are changed as follows on Windows. > > > > (1) pgevent.dll > > PG16: lib/ > > PG17: bin/ > > > > (2) dll for user (like libpq.dll, libecpg.dll) > > PG16: Both

Re: doc: pgevent.dll location

2024-11-06 Thread Peter Eisentraut
On 06.11.24 13:57, Ryohei Takahashi (Fujitsu) wrote: The dll install paths are changed as follows on Windows. (1) pgevent.dll PG16: lib/ PG17: bin/ (2) dll for user (like libpq.dll, libecpg.dll) PG16: Both in lib/ and bin/ PG17: bin/ (3) contrib dll (like amcheck.dll) PG16: lib/ PG17: lib/ I

RE: doc: pgevent.dll location

2024-11-06 Thread Ryohei Takahashi (Fujitsu)
Hi, Thank you for your reply. The dll install paths are changed as follows on Windows. (1) pgevent.dll PG16: lib/ PG17: bin/ (2) dll for user (like libpq.dll, libecpg.dll) PG16: Both in lib/ and bin/ PG17: bin/ (3) contrib dll (like amcheck.dll) PG16: lib/ PG17: lib/ I understand that Dave

Re: doc: pgevent.dll location

2024-11-05 Thread Dave Page
On Tue, 5 Nov 2024 at 15:10, Robert Haas wrote: > On Tue, Nov 5, 2024 at 1:00 AM Gurjeet Singh wrote: > > I'm unable to confirm the veracity of the claim that the pgevent.dll > > file on Windows is now placed in a different directory, and that this > > is a result of meson builds. But the patch

Re: doc: pgevent.dll location

2024-11-05 Thread Tom Lane
Robert Haas writes: > On Tue, Nov 5, 2024 at 1:00 AM Gurjeet Singh wrote: >> I'm unable to confirm the veracity of the claim that the pgevent.dll >> file on Windows is now placed in a different directory, and that this >> is a result of meson builds. But the patch looks good to me; it >> applies

Re: doc: pgevent.dll location

2024-11-05 Thread Robert Haas
On Tue, Nov 5, 2024 at 1:00 AM Gurjeet Singh wrote: > I'm unable to confirm the veracity of the claim that the pgevent.dll > file on Windows is now placed in a different directory, and that this > is a result of meson builds. But the patch looks good to me; it > applies cleanly to REL_17_STABLE an

Re: doc: pgevent.dll location

2024-11-04 Thread Gurjeet Singh
On Mon, Nov 4, 2024 at 7:02 PM Ryohei Takahashi (Fujitsu) wrote: > > On the other hand, pgevent.dll is moved from lib/ directory to bin/directory > on PG 17.0 > > (It seems that it is moved because of meson) > > So, I think the documentation need to be updated like attached. I'm unable to confir

doc: pgevent.dll location

2024-11-04 Thread Ryohei Takahashi (Fujitsu)
Hi, PostgreSQL 17.0 Documentation teach us to run the following command. regsvr32 pgsql_library_directory/pgevent.dll On the other hand, pgevent.dll is moved from lib/ directory to bin/directory on PG 17.0 (It seems that it is moved because of meson) So, I think the documentation need to be