On Tue, 5 Nov 2024 at 15:10, Robert Haas <robertmh...@gmail.com> wrote:
> On Tue, Nov 5, 2024 at 1:00 AM Gurjeet Singh <gurj...@singh.im> wrote: > > I'm unable to confirm the veracity of the claim that the pgevent.dll > > file on Windows is now placed in a different directory, and that this > > is a result of meson builds. But the patch looks good to me; it > > applies cleanly to REL_17_STABLE and main branches. > > I think we will need to find someone who can confirm whether or not > the claim is correct. > It is correct. In v16, it was in lib/, in v17, bin/. However, on Windows I think it probably makes (marginally) more sense to include it in bin/ - we already have other libraries in there that are linked at compile time. pgevent is something of a special case, but it's probably more similar to those libraries than the extensions etc. that are in lib/. Related sidenote: I got a complaint today that pg_regress.exe is no longer part of the Windows installation footprint - and indeed, it's not installed at all with Meson builds, which is problematic for those doing CI/CD testing of extensions. -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org
