Re: doc: BRIN indexes and autosummarize

2022-07-06 Thread Alvaro Herrera
On 2022-Jul-05, Justin Pryzby wrote: > One issue: > > + summarized range, the range that the new page belongs into > + does not automatically acquire a summary tuple; > > "belongs into" sounds wrong - "belongs to" is better. Hah, and I was wondering if "belongs in" was any better. > I'll p

Re: doc: BRIN indexes and autosummarize

2022-07-05 Thread Justin Pryzby
On Tue, Jul 05, 2022 at 01:47:27PM +0200, Alvaro Herrera wrote: > OK, I have adopted all your proposed changes, thanks for submitting in > both forms. I did some more wordsmithing and pushed, to branches 12 and > up. 11 fails 'make check', I think for lack of Docbook id tags, and I > didn't want

Re: doc: BRIN indexes and autosummarize

2022-07-05 Thread Alvaro Herrera
On 2022-Jul-05, Roberto Mello wrote: > You removed the reference to the functions' documentation at > functions-admin-index choosing instead to duplicate a summarized > version of the docs, and to boot getting the next block to be blobbed > together with it. Actually, my first instinct was to mov

Re: doc: BRIN indexes and autosummarize

2022-07-05 Thread Roberto Mello
On Tue, Jul 5, 2022 at 5:47 AM Alvaro Herrera wrote: > OK, I have adopted all your proposed changes, thanks for submitting in > both forms. I did some more wordsmithing and pushed, to branches 12 and > up. 11 fails 'make check', I think for lack of Docbook id tags, and I > didn't want to waste

Re: doc: BRIN indexes and autosummarize

2022-07-05 Thread Roberto Mello
On Mon, Jul 4, 2022 at 9:20 AM Alvaro Herrera wrote: > > [Some of] these additions are wrong actually. It says that autovacuum > will not summarize new entries; but it does. If you just let the table > sit idle, any autovacuum run that cleans the table will also summarize > any ranges that need

Re: doc: BRIN indexes and autosummarize

2022-07-05 Thread Alvaro Herrera
On 2022-Jul-04, Jaime Casanova wrote: > I feel that somewhere in this paragraph it should be mentioned that is > off by default. OK, I added it. On 2022-Jul-04, Justin Pryzby wrote: > [ lots of comments ] OK, I have adopted all your proposed changes, thanks for submitting in both forms. I did

Re: doc: BRIN indexes and autosummarize

2022-07-04 Thread Justin Pryzby
On Mon, Jul 04, 2022 at 09:38:42PM +0200, Alvaro Herrera wrote: > + There are several triggers for initial summarization of a page range > + to occur. If the table is vacuumed, either because > +has been manually invoked or because > + autovacuum causes it, > + all existing unsummarize

Re: doc: BRIN indexes and autosummarize

2022-07-04 Thread Jaime Casanova
On Mon, Jul 04, 2022 at 09:38:42PM +0200, Alvaro Herrera wrote: > What about this? > > -- > Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ > "Java is clearly an example of money oriented programming" (A. Stepanov) > diff --git a/doc/src/sgml/brin.sgml b/doc/src/sg

Re: doc: BRIN indexes and autosummarize

2022-07-04 Thread Alvaro Herrera
What about this? -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Java is clearly an example of money oriented programming" (A. Stepanov) diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml index caf1ea4cef..0a715d41c7 100644 --- a/doc/src/sgml/brin.sgml

Re: doc: BRIN indexes and autosummarize

2022-07-04 Thread Alvaro Herrera
On 2022-Jun-28, Roberto Mello wrote: > Here's a patch to clarify the BRIN indexes documentation, particularly with > regards to autosummarize, vacuum and autovacuum. It basically breaks > down a big blob of a paragraph into multiple paragraphs for clarity, > plus explicitly tells how summarization

Re: doc: BRIN indexes and autosummarize

2022-06-29 Thread Justin Pryzby
On Tue, Jun 28, 2022 at 05:22:34PM -0600, Roberto Mello wrote: > Here's a patch to clarify the BRIN indexes documentation, particularly with > regards to autosummarize, vacuum and autovacuum. It basically breaks down a > big blob of a paragraph into multiple paragraphs for clarity, plus explicitly

doc: BRIN indexes and autosummarize

2022-06-28 Thread Roberto Mello
Here's a patch to clarify the BRIN indexes documentation, particularly with regards to autosummarize, vacuum and autovacuum. It basically breaks down a big blob of a paragraph into multiple paragraphs for clarity, plus explicitly tells how summarization happens manually or automatically. I also ad