Re: copy_file_range is now a Linux kernel call

2018-01-03 Thread Andres Freund
On 2018-01-02 23:34:47 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-01-02 23:08:05 -0500, Tom Lane wrote: > >> Bleah --- "rwnd" is unpronounceable and not an abbreviation we're > >> currently using anywhere. If we go that way, let's brave carpal tunnel > >> syndrome by calling it "r

Re: copy_file_range is now a Linux kernel call

2018-01-02 Thread Tom Lane
Andres Freund writes: > On 2018-01-02 23:08:05 -0500, Tom Lane wrote: >> Bleah --- "rwnd" is unpronounceable and not an abbreviation we're >> currently using anywhere. If we go that way, let's brave carpal tunnel >> syndrome by calling it "rewind_copy_file_range". But I'm not that >> happy with

Re: copy_file_range is now a Linux kernel call

2018-01-02 Thread Andres Freund
Hi, On 2018-01-02 23:08:05 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-01-02 22:44:04 -0500, Tom Lane wrote: > > something like rwnd_copy_file_range or such. > Bleah --- "rwnd" is unpronounceable and not an abbreviation we're > currently using anywhere. If we go that way, let's b

Re: copy_file_range is now a Linux kernel call

2018-01-02 Thread Tom Lane
Andres Freund writes: > On 2018-01-02 22:44:04 -0500, Tom Lane wrote: >> Looks like we'd better rename our function. Anybody have an idea >> more creative than "pg_copy_file_range"? > I'd rather name it pg_rewind specific, OK ... > something like > rwnd_copy_file_range or such. Bleah --- "rwn

Re: copy_file_range is now a Linux kernel call

2018-01-02 Thread Andres Freund
Hi, On 2018-01-02 22:44:04 -0500, Tom Lane wrote: > Buildfarm member caiman just came back online after some time AWOL, and > it's not happy. The problem evidently is that pg_rewind's copy_file_range > function conflicts with a recently added Linux system call: > > http://man7.org/linux/man-page

copy_file_range is now a Linux kernel call

2018-01-02 Thread Tom Lane
Buildfarm member caiman just came back online after some time AWOL, and it's not happy. The problem evidently is that pg_rewind's copy_file_range function conflicts with a recently added Linux system call: http://man7.org/linux/man-pages/man2/copy_file_range.2.html Looks like we'd better rename