Re: connection establishment versus parallel workers

2025-02-06 Thread Thomas Munro
On Mon, Jan 20, 2025 at 6:33 PM Thomas Munro wrote: > Here's the WIP code I have up with for that so far. > > Remaining opportunities not attempted: > 1. When a child exits, we could use a hash table to find it by pid. > 2. When looking for a bgworker slot that is not in use, we could do > somet

Re: connection establishment versus parallel workers

2025-01-19 Thread Thomas Munro
On Tue, Jan 14, 2025 at 9:42 AM Thomas Munro wrote: > On Tue, Jan 14, 2025 at 8:50 AM Nathan Bossart > wrote: > > I gave these a closer look, and I still feel that they are both > > straightforward and reasonable. IIUC the main open question is whether > > this might cause problems for other PM

Re: connection establishment versus parallel workers

2025-01-13 Thread Thomas Munro
On Tue, Jan 14, 2025 at 8:50 AM Nathan Bossart wrote: > On Thu, Dec 19, 2024 at 10:09:35AM -0600, Nathan Bossart wrote: > > On Fri, Dec 13, 2024 at 03:56:00PM +1300, Thomas Munro wrote: > >> 0001 patch is unchanged, 0002 patch sketches out a response to the > >> observation a couple of paragraphs

Re: connection establishment versus parallel workers

2025-01-13 Thread Nathan Bossart
On Thu, Dec 19, 2024 at 10:09:35AM -0600, Nathan Bossart wrote: > On Fri, Dec 13, 2024 at 03:56:00PM +1300, Thomas Munro wrote: >> 0001 patch is unchanged, 0002 patch sketches out a response to the >> observation a couple of paragraphs above. > > Both of these patches seem to improve matters quite

Re: connection establishment versus parallel workers

2024-12-19 Thread Nathan Bossart
Sorry for the delay, and thanks again for digging into this. On Fri, Dec 13, 2024 at 03:56:00PM +1300, Thomas Munro wrote: > 0001 patch is unchanged, 0002 patch sketches out a response to the > observation a couple of paragraphs above. Both of these patches seem to improve matters quite a bit. I

Re: connection establishment versus parallel workers

2024-12-12 Thread Thomas Munro
On Fri, Dec 13, 2024 at 11:00 AM Nathan Bossart wrote: > On Fri, Dec 13, 2024 at 02:29:53AM +1300, Thomas Munro wrote: > > Here's an experimental patch to try changing that policy. It improves > > the connection times on my small computer with your test, but I doubt > > I'm seeing the real issue.

Re: connection establishment versus parallel workers

2024-12-12 Thread Nathan Bossart
On Fri, Dec 13, 2024 at 02:29:53AM +1300, Thomas Munro wrote: > Here's an experimental patch to try changing that policy. It improves > the connection times on my small computer with your test, but I doubt > I'm seeing the real issue. But in theory, assuming a backlog of > connections and workers

Re: connection establishment versus parallel workers

2024-12-12 Thread Thomas Munro
On Thu, Dec 12, 2024 at 11:36 AM Thomas Munro wrote: > On Thu, Dec 12, 2024 at 9:43 AM Nathan Bossart > wrote: > > Our theory is that commit 7389aad (and follow-ups like commit 239b175) made > > parallel worker processing much more responsive to the point of contending > > with incoming connecti

Re: connection establishment versus parallel workers

2024-12-11 Thread Thomas Munro
On Thu, Dec 12, 2024 at 11:36 AM Thomas Munro wrote: > ... instead of > reporting only the lowest priority one) s/priority/position/

Re: connection establishment versus parallel workers

2024-12-11 Thread Thomas Munro
On Thu, Dec 12, 2024 at 9:43 AM Nathan Bossart wrote: > My team recently received a report about connection establishment times > increasing substantially from v16 onwards. Upon further investigation, > this seems to have something to do with commit 7389aad (which moved a lot > of postmaster code

connection establishment versus parallel workers

2024-12-11 Thread Nathan Bossart
My team recently received a report about connection establishment times increasing substantially from v16 onwards. Upon further investigation, this seems to have something to do with commit 7389aad (which moved a lot of postmaster code out of signal handlers) in conjunction with workloads that gen