Re: benign bug in BufFileLoadBuffer / incorrect sizeof

2025-01-12 Thread Daniel Gustafsson
> On 12 Jan 2025, at 17:10, Tomas Vondra wrote: > > Hi, > > While experimenting with some changes in BufFile, I noticed a harmless > bug in BufFileLoadBuffer. It calls sizeof on the whole PGAlignedBuffer, > instead of just on the "data" field. It's benign because the "data" is > the largest part

benign bug in BufFileLoadBuffer / incorrect sizeof

2025-01-12 Thread Tomas Vondra
Hi, While experimenting with some changes in BufFile, I noticed a harmless bug in BufFileLoadBuffer. It calls sizeof on the whole PGAlignedBuffer, instead of just on the "data" field. It's benign because the "data" is the largest part of the union, so the sizes are equal. But it's still confusing