> On 12 Jan 2025, at 17:10, Tomas Vondra <to...@vondra.me> wrote: > > Hi, > > While experimenting with some changes in BufFile, I noticed a harmless > bug in BufFileLoadBuffer. It calls sizeof on the whole PGAlignedBuffer, > instead of just on the "data" field. It's benign because the "data" is > the largest part of the union, so the sizes are equal. > > But it's still confusing, it took me a while my experimental patch > fails. So I think it'd be good to correct it.
Nice catch, patch LGTM. -- Daniel Gustafsson