Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-14 Thread Bruce Momjian
On Fri, Jun 11, 2021 at 09:40:07PM -0400, Bruce Momjian wrote: > On Fri, Jun 11, 2021 at 09:17:46PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > OK, I used some of your ideas and tried for something more general; > > > patch attached. > > > > I think it's a good idea to mention custom

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Bruce Momjian
On Fri, Jun 11, 2021 at 08:19:48PM -0500, Justin Pryzby wrote: > On Fri, Jun 11, 2021 at 09:12:55PM -0400, Bruce Momjian wrote: > > OK, I used some of your ideas and tried for something more general; > > patch attached. > > This is good. > > But I wonder if "dropped before upgrading" is too spec

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Bruce Momjian
On Fri, Jun 11, 2021 at 09:17:46PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > OK, I used some of your ideas and tried for something more general; > > patch attached. > > I think it's a good idea to mention custom aggregates and operators > specifically, as otherwise people will look at t

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Justin Pryzby
On Fri, Jun 11, 2021 at 09:12:55PM -0400, Bruce Momjian wrote: > OK, I used some of your ideas and tried for something more general; > patch attached. This is good. But I wonder if "dropped before upgrading" is too specific to pg_upgrade? Dropping the aggregate before starting a backup to be re

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Tom Lane
Bruce Momjian writes: > OK, I used some of your ideas and tried for something more general; > patch attached. I think it's a good idea to mention custom aggregates and operators specifically, as otherwise people will look at this and have little idea what you're on about. I just want wording li

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Bruce Momjian
On Fri, Jun 11, 2021 at 08:56:19PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > OK, I came up with the attached patch. This is one of the few cases > > where the incompatibility is not clearly related to the feature, so I > > left the existing item alone and just created a new one with the

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Tom Lane
Bruce Momjian writes: > OK, I came up with the attached patch. This is one of the few cases > where the incompatibility is not clearly related to the feature, so I > left the existing item alone and just created a new one with the same > commit message in the incompatibilities section. I think p

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-11 Thread Bruce Momjian
On Tue, Jun 8, 2021 at 07:10:00PM -0500, Justin Pryzby wrote: > On Tue, Jun 08, 2021 at 08:02:46PM -0400, Bruce Momjian wrote: > > This involves creating an aggreate that _uses_ these array functions as > > their state transition function? > > Yes OK, I came up with the attached patch. This is

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-08 Thread Justin Pryzby
On Tue, Jun 08, 2021 at 08:02:46PM -0400, Bruce Momjian wrote: > This involves creating an aggreate that _uses_ these array functions as > their state transition function? Yes -- Justin

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-08 Thread Bruce Momjian
On Tue, Jun 8, 2021 at 05:56:18PM -0500, Justin Pryzby wrote: > @Bruce: Would you add something about this to the release notes before beta2? > > I added it as an OpenItem. OK, see below. > On Tue, May 25, 2021 at 11:14:58AM -0500, Justin Pryzby wrote: > > On Thu, May 20, 2021 at 07:35:10PM -04

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

2021-06-08 Thread Justin Pryzby
@Bruce: Would you add something about this to the release notes before beta2? I added it as an OpenItem. On Tue, May 25, 2021 at 11:14:58AM -0500, Justin Pryzby wrote: > On Thu, May 20, 2021 at 07:35:10PM -0400, Tom Lane wrote: > > Justin Pryzby writes: > > > On Wed, Nov 04, 2020 at 07:43:51PM -