Re: access/parallel.h lacks PGDLLIMPORT

2017-12-19 Thread Craig Ringer
On 19 December 2017 at 23:24, Robert Haas wrote: > On Tue, Dec 19, 2017 at 3:36 AM, Amit Kapila > wrote: > > I also think it is good to allow ParallelWorkerNumber to be used in > > extensions. Attached is the patch for same. I think for other two we > > should wait till there is really a good

Re: access/parallel.h lacks PGDLLIMPORT

2017-12-19 Thread Robert Haas
On Tue, Dec 19, 2017 at 3:36 AM, Amit Kapila wrote: > I also think it is good to allow ParallelWorkerNumber to be used in > extensions. Attached is the patch for same. I think for other two we > should wait till there is really a good use case for them. I think waiting for a "really good" use c

Re: access/parallel.h lacks PGDLLIMPORT

2017-12-19 Thread Amit Kapila
On Thu, Dec 14, 2017 at 8:42 PM, Robert Haas wrote: > On Wed, Dec 13, 2017 at 8:19 PM, Thomas Munro > wrote: >> I suppose that extensions are supposed to be allowed to use the >> facilities in access/parallel.h. I noticed in passing when I wrote a >> throwaway test harness that my Windows built

Re: access/parallel.h lacks PGDLLIMPORT

2017-12-14 Thread Robert Haas
On Wed, Dec 13, 2017 at 8:19 PM, Thomas Munro wrote: > I suppose that extensions are supposed to be allowed to use the > facilities in access/parallel.h. I noticed in passing when I wrote a > throwaway test harness that my Windows built drone complained: > > test_sharedtuplestore.obj : error LNK2

access/parallel.h lacks PGDLLIMPORT

2017-12-13 Thread Thomas Munro
Hi hackers, I suppose that extensions are supposed to be allowed to use the facilities in access/parallel.h. I noticed in passing when I wrote a throwaway test harness that my Windows built drone complained: test_sharedtuplestore.obj : error LNK2001: unresolved external symbol ParallelWorkerNumb