Re: Windows: openssl & gssapi dislike each other

2024-07-10 Thread Imran Zaheer
On Tue, Jul 9, 2024 at 2:32 AM Andres Freund wrote: > > Hi, > > > On 2024-06-13 00:12:51 +0900, Imran Zaheer wrote: > > I removed the macro from the sslinfo.c as suggested by Andrew. Then I > > was thinking maybe we can undo some other similar code. > > What precisely do you mean by that? Just get

Re: Windows: openssl & gssapi dislike each other

2024-07-08 Thread Andres Freund
Hi, On 2024-06-13 00:12:51 +0900, Imran Zaheer wrote: > I removed the macro from the sslinfo.c as suggested by Andrew. Then I > was thinking maybe we can undo some other similar code. What precisely do you mean by that? Just getting rid of the "ordered include" of openssl headers in {fe,be}-secu

Re: Windows: openssl & gssapi dislike each other

2024-06-12 Thread Imran Zaheer
Hi I removed the macro from the sslinfo.c as suggested by Andrew. Then I was thinking maybe we can undo some other similar code. I rearranged the headers to their previous position in be-secure-openssl.c and in fe-secure-openssl.c. I was able to compile with gssapi and openssl enabled. You can lo

Re: Windows: openssl & gssapi dislike each other

2024-06-11 Thread Dave Page
On Tue, 11 Jun 2024 at 12:22, Andrew Dunstan wrote: > > On 2024-06-11 Tu 05:19, Dave Page wrote: > > Hi > > On Sun, 9 Jun 2024 at 08:29, Imran Zaheer wrote: > >> Hi >> >> I am submitting two new patches. We can undefine the macro at two >> locations >> >> 1). As be-secure-openssl.c [1] was the a

Re: Windows: openssl & gssapi dislike each other

2024-06-11 Thread Andrew Dunstan
On 2024-06-11 Tu 05:19, Dave Page wrote: Hi On Sun, 9 Jun 2024 at 08:29, Imran Zaheer wrote: Hi I am submitting two new patches. We can undefine the macro at two locations 1). As be-secure-openssl.c [1] was the actual file where the conflict happened so I undefined the m

Re: Windows: openssl & gssapi dislike each other

2024-06-11 Thread Dave Page
Hi On Sun, 9 Jun 2024 at 08:29, Imran Zaheer wrote: > Hi > > I am submitting two new patches. We can undefine the macro at two locations > > 1). As be-secure-openssl.c [1] was the actual > file where the conflict happened so I undefined the macro here before > the ssl includes. I changed the com

Re: Windows: openssl & gssapi dislike each other

2024-06-09 Thread Imran Zaheer
Hi I am submitting two new patches. We can undefine the macro at two locations 1). As be-secure-openssl.c [1] was the actual file where the conflict happened so I undefined the macro here before the ssl includes. I changed the comment a little to make it understandable. I am also attaching the er

Re: Windows: openssl & gssapi dislike each other

2024-06-08 Thread Tom Lane
Andrew Dunstan writes: > On 2024-06-08 Sa 06:22, Imran Zaheer wrote: >> Now this can either be solved by just just undefine the macro defined >> by wincrypt.h as done here [3] >> Or we should rearrange our headers. Openssl header should be at the >> bottom (after the gssapi includes). > Let's be

Re: Windows: openssl & gssapi dislike each other

2024-06-08 Thread Andrew Dunstan
On 2024-06-08 Sa 06:22, Imran Zaheer wrote: I was able to reproduce the gssapi & openssl error on windows. I tried on PG16 with msvc build system and on PG17 with meson build system. The error was reproducible when enabling both openssl and gssapi from the configurations. Turns out that it was

Re: Windows: openssl & gssapi dislike each other

2024-06-08 Thread Imran Zaheer
I was able to reproduce the gssapi & openssl error on windows. I tried on PG16 with msvc build system and on PG17 with meson build system. The error was reproducible when enabling both openssl and gssapi from the configurations. Turns out that it was due to the conflicting macros. "be-secure-open

Windows: openssl & gssapi dislike each other

2024-05-28 Thread Dave Page
I recently noticed that at least with PostgreSQL 16, it is not possible to build using MSVC if both OpenSSL and gssapi (MIT Kerberos) are enabled. Both work if the other isn't included though.. I briefly tried to test with PG17 to see if it has the same issue, but it seems like gssapi has the same