Re: Unnecessary call to resetPQExpBuffer in getIndexes

2022-02-10 Thread Julien Rouhaud
On Thu, Feb 10, 2022 at 12:25:36PM +0100, Peter Eisentraut wrote: > On 09.02.22 19:21, Nathan Bossart wrote: > > On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote: > > > I just noticed that e2c52beecd (adding PeterE in Cc) added a > > > resetPQExpBuffer() > > > which seems unnecessary

Re: Unnecessary call to resetPQExpBuffer in getIndexes

2022-02-10 Thread Peter Eisentraut
On 09.02.22 19:21, Nathan Bossart wrote: On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote: I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer() which seems unnecessary since the variable is untouched since the initial createPQExpBuffer(). Simple patch at

Re: Unnecessary call to resetPQExpBuffer in getIndexes

2022-02-09 Thread Nathan Bossart
On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote: > I just noticed that e2c52beecd (adding PeterE in Cc) added a > resetPQExpBuffer() > which seems unnecessary since the variable is untouched since the initial > createPQExpBuffer(). > > Simple patch attached. LGTM -- Nathan Bossa

Unnecessary call to resetPQExpBuffer in getIndexes

2022-02-08 Thread Julien Rouhaud
Hi, I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer() which seems unnecessary since the variable is untouched since the initial createPQExpBuffer(). Simple patch attached. >From 1ebddb696af3b77f7d373034b938a358529a9ea1 Mon Sep 17 00:00:00 2001 From: Julien Rouhaud D