Hi,
I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
which seems unnecessary since the variable is untouched since the initial
createPQExpBuffer().
Simple patch attached.
>From 1ebddb696af3b77f7d373034b938a358529a9ea1 Mon Sep 17 00:00:00 2001
From: Julien Rouhaud <julien.rouh...@free.fr>
Date: Wed, 9 Feb 2022 10:36:07 +0800
Subject: [PATCH v1] Remove unnecessary resetPQExpBuffer call.
Oversight in e2c52beecdea152ca680a22ef35c6a7da55aa30f.
---
src/bin/pg_dump/pg_dump.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 3499c0a4d5..3b4b63d897 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -6524,8 +6524,6 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int
numTables)
}
appendPQExpBufferChar(tbloids, '}');
- resetPQExpBuffer(query);
-
appendPQExpBuffer(query,
"SELECT t.tableoid, t.oid,
i.indrelid, "
"t.relname AS indexname, "
--
2.35.0
