Re: Take skip header out of a loop in COPY FROM

2019-09-24 Thread Tom Lane
Heikki Linnakangas writes: > On 22/08/2019 12:54, Adam Lee wrote: >> My next thought is to call unlikely() here, but we don't have it... > We do, actually, since commit aa3ca5e3dd in v10. > Not sure it's worth the trouble here. Optimizing COPY in general would > be good, even small speedups the

Re: Take skip header out of a loop in COPY FROM

2019-08-22 Thread Heikki Linnakangas
On 22/08/2019 12:54, Adam Lee wrote: My next thought is to call unlikely() here, but we don't have it... https://www.postgresql.org/message-id/CABRT9RC-AUuQL6txxsoOkLxjK1iTpyexpbizRF4Zxny1GXASGg%40mail.gmail.com We do, actually, since commit aa3ca5e3dd in v10. Not sure it's worth the trouble h

Re: Take skip header out of a loop in COPY FROM

2019-08-22 Thread Adam Lee
On Thu, Aug 22, 2019 at 11:48:31AM +0300, Heikki Linnakangas wrote: > On 22/08/2019 11:31, Surafel Temesgen wrote: > > Hello, > > > > Even if skipping header is done only once its checked and skipped in a > > loop. If I don’t miss something it can be done out side a loop like > > attached patch >

Re: Take skip header out of a loop in COPY FROM

2019-08-22 Thread Heikki Linnakangas
On 22/08/2019 11:31, Surafel Temesgen wrote: Hello, Even if skipping header is done only once its checked and skipped in a loop. If I don’t miss something it can be done out side a loop like attached patch You may be on to something, but if we move it to CopyFrom(), as in your patch, then i

Take skip header out of a loop in COPY FROM

2019-08-22 Thread Surafel Temesgen
Hello, Even if skipping header is done only once its checked and skipped in a loop. If I don’t miss something it can be done out side a loop like attached patch regards Surafel diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 4f04d122c3..4e7709d7bf 100644 --- a/src/ba