On Thu, Aug 22, 2019 at 11:48:31AM +0300, Heikki Linnakangas wrote: > On 22/08/2019 11:31, Surafel Temesgen wrote: > > Hello, > > > > Even if skipping header is done only once its checked and skipped in a > > loop. If I don’t miss something it can be done out side a loop like > > attached patch > > You may be on to something, but if we move it to CopyFrom(), as in your > patch, then it won't get executed e.g. from the calls in file_fdw. file_fdw > calls BeginCopyFrom(), followed by NextCopyFrom(); it doesn't use > CopyFrom(). > > - Heikki
Yes. My next thought is to call unlikely() here, but we don't have it... https://www.postgresql.org/message-id/CABRT9RC-AUuQL6txxsoOkLxjK1iTpyexpbizRF4Zxny1GXASGg%40mail.gmail.com -- Adam Lee
