Re: Small TAP tests cleanup for Windows and unused modules

2022-03-27 Thread Daniel Gustafsson
> On 27 Mar 2022, at 00:20, Daniel Gustafsson wrote: > I'll take it for a tour on the CI and will then apply. Which is now done, thanks! -- Daniel Gustafsson https://vmware.com/

Re: Small TAP tests cleanup for Windows and unused modules

2022-03-26 Thread Daniel Gustafsson
> On 25 Mar 2022, at 13:42, Dagfinn Ilmari Mannsåker wrote: > A quick git grep¹ revealed a few more extraneous `use Config;` > statements (and manual inspection a few more unused modules in one > file). Thanks for digging these up, they look correct to me. > src/bin/pg_ctl/t/001_start_stop.pl |

Re: Small TAP tests cleanup for Windows and unused modules

2022-03-25 Thread Dagfinn Ilmari Mannsåker
Daniel Gustafsson writes: >> On 18 Feb 2022, at 22:02, Daniel Gustafsson wrote: > >> .. let's drop the 0001 from this thread and just go ahead with 0002. > > I applied the 0002 patch today, cleaning up the unused module imports. A quick git grep¹ revealed a few more extraneous `use Config;` sta

Re: Small TAP tests cleanup for Windows and unused modules

2022-03-24 Thread Daniel Gustafsson
> On 18 Feb 2022, at 22:02, Daniel Gustafsson wrote: > .. let's drop the 0001 from this thread and just go ahead with 0002. I applied the 0002 patch today, cleaning up the unused module imports. -- Daniel Gustafsson https://vmware.com/

Re: Small TAP tests cleanup for Windows and unused modules

2022-02-18 Thread Daniel Gustafsson
> On 16 Feb 2022, at 23:36, Andrew Dunstan wrote: > On 2/16/22 17:04, Andrew Dunstan wrote: >> On 2/16/22 16:36, Daniel Gustafsson wrote: >>> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about >>> two related (well, one of them) patches I had sitting around, so rather tha

Re: Small TAP tests cleanup for Windows and unused modules

2022-02-16 Thread Michael Paquier
On Wed, Feb 16, 2022 at 05:36:14PM -0500, Andrew Dunstan wrote: > More specifically, all the tests in question are now passing on jacana > and fairywren, and their $Config{osname} is NOT 'msys' (it's 'MSWin32'). Indeed. 0001 is incorrect. > So we should simply remove any line that ends "if $Conf

Re: Small TAP tests cleanup for Windows and unused modules

2022-02-16 Thread Andres Freund
Hi, On February 16, 2022 2:04:01 PM PST, Andrew Dunstan wrote: > >On 2/16/22 16:36, Daniel Gustafsson wrote: >> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about >> two related (well, one of them) patches I had sitting around, so rather than >> forgetting again here ar

Re: Small TAP tests cleanup for Windows and unused modules

2022-02-16 Thread Andrew Dunstan
On 2/16/22 17:04, Andrew Dunstan wrote: > On 2/16/22 16:36, Daniel Gustafsson wrote: >> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about >> two related (well, one of them) patches I had sitting around, so rather than >> forgetting again here are some small cleanups. >>

Re: Small TAP tests cleanup for Windows and unused modules

2022-02-16 Thread Daniel Gustafsson
> On 16 Feb 2022, at 23:04, Andrew Dunstan wrote: > > On 2/16/22 16:36, Daniel Gustafsson wrote: >> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about >> two related (well, one of them) patches I had sitting around, so rather than >> forgetting again here are some small

Re: Small TAP tests cleanup for Windows and unused modules

2022-02-16 Thread Andrew Dunstan
On 2/16/22 16:36, Daniel Gustafsson wrote: > Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about > two related (well, one of them) patches I had sitting around, so rather than > forgetting again here are some small cleanups. > > 0001 attempts to streamline how we detect W

Small TAP tests cleanup for Windows and unused modules

2022-02-16 Thread Daniel Gustafsson
Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about two related (well, one of them) patches I had sitting around, so rather than forgetting again here are some small cleanups. 0001 attempts to streamline how we detect Windows in the TAP tests (after that there is a single