> On 16 Feb 2022, at 23:04, Andrew Dunstan <and...@dunslane.net> wrote: > > On 2/16/22 16:36, Daniel Gustafsson wrote: >> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about >> two related (well, one of them) patches I had sitting around, so rather than >> forgetting again here are some small cleanups. >> >> 0001 attempts to streamline how we detect Windows in the TAP tests (after >> that >> there is a single msys check left that I'm not sure about, but [1] seems to >> imply it could go); 0002 removes some unused module includes which either >> were >> used at some point in the past or likely came from copy/paste. >> > > 0002 looks OK at first glance.
Thanks! > 0001 is something we should investigate. It's really going in the wrong > direction I suspect. We should be looking to narrow the scope of these > platform-specific bits of processing, not expand them. No arguments there, I was only looking at making sure that we detect the OS in the same way everywhere, but if you're working towards eliminating this there is little use in changing anything. -- Daniel Gustafsson https://vmware.com/
