Re: SQLSTATE for replication connection failures

2021-06-16 Thread Tom Lane
Masahiko Sawada writes: > On Mon, Jun 14, 2021 at 6:18 PM Amit Kapila wrote: >>> Shall we just use ERRCODE_CONNECTION_FAILURE for these failures, or >>> would it be better to invent another SQLSTATE code? Arguably, >>> ERRCODE_CONNECTION_FAILURE is meant for failures of client connections; >>> b

Re: SQLSTATE for replication connection failures

2021-06-15 Thread Masahiko Sawada
On Mon, Jun 14, 2021 at 6:18 PM Amit Kapila wrote: > > On Sat, Jun 12, 2021 at 9:12 PM Tom Lane wrote: > > > > So far as I can find, just about everyplace that deals with replication > > connections has slipshod error reporting. An example from worker.c is > > > > LogRepWorkerWalRcvConn

Re: SQLSTATE for replication connection failures

2021-06-14 Thread Amit Kapila
On Sat, Jun 12, 2021 at 9:12 PM Tom Lane wrote: > > So far as I can find, just about everyplace that deals with replication > connections has slipshod error reporting. An example from worker.c is > > LogRepWorkerWalRcvConn = walrcv_connect(MySubscription->conninfo, > true, >

SQLSTATE for replication connection failures

2021-06-12 Thread Tom Lane
So far as I can find, just about everyplace that deals with replication connections has slipshod error reporting. An example from worker.c is LogRepWorkerWalRcvConn = walrcv_connect(MySubscription->conninfo, true, MySubscription->name, &err)