Peter Eisentraut writes:
> On 12/21/17 08:13, Andrew Dunstan wrote:
>> Looks reasonable. Regarding the change to TestLib.pm, we should make
>> sure that the tests have unique names. There is a small amount of
>> duplication currently:
>>
>> ./src/bin/pg_dump/t/001_basic.pl
>> ./src/bin/pg_rewind/
On Mon, Dec 25, 2017 at 2:25 AM, Peter Eisentraut
wrote:
> On 12/21/17 08:13, Andrew Dunstan wrote:
>> Looks reasonable. Regarding the change to TestLib.pm, we should make
>> sure that the tests have unique names. There is a small amount of
>> duplication currently:
>>
>> ./src/bin/pg_dump/t/
On Sun, Dec 24, 2017 at 12:26:53PM -0500, Peter Eisentraut wrote:
> On 12/20/17 21:50, Tom Lane wrote:
> > -my $this_script = $0;
> > +my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_BIG5.pl';
>
> This kind of things looks awful. Why is this better?
What's wrong with using the path? As y
On 12/20/17 21:50, Tom Lane wrote:
> -my $this_script = $0;
> +my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_BIG5.pl';
This kind of things looks awful. Why is this better?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Tra
On 12/21/17 08:13, Andrew Dunstan wrote:
> Looks reasonable. Regarding the change to TestLib.pm, we should make
> sure that the tests have unique names. There is a small amount of
> duplication currently:
>
> ./src/bin/pg_dump/t/001_basic.pl
> ./src/bin/pg_rewind/t/001_basic.pl
> ./src
Andrew Dunstan writes:
> Looks reasonable. Regarding the change to TestLib.pm, we should make
> sure that the tests have unique names. There is a small amount of
> duplication currently:
> ./src/bin/pg_dump/t/001_basic.pl
> ./src/bin/pg_rewind/t/001_basic.pl
> ./src/test/modules/commi
Christoph Berg wrote:
> Re: Andrew Dunstan 2017-12-21
>
> > I've found it annoying in the past. Probably now that the buildfarm
> > reports each test series separately it matters less. Previously we
> > reported many of the TAP tests together.
>
> Rename them to the directory name:
>
> ./s
Re: Andrew Dunstan 2017-12-21
> >> ./src/bin/pg_dump/t/001_basic.pl
> >> ./src/bin/pg_rewind/t/001_basic.pl
> >> ./src/test/modules/commit_ts/t/001_base.pl
> >> ./src/test/modules/test_pg_dump/t/001_base.pl
> > Why does the uniqueness of application_name set in the TAP test suite
On 12/21/2017 08:27 AM, Michael Paquier wrote:
> On Thu, Dec 21, 2017 at 10:13 PM, Andrew Dunstan
> wrote:
>> Looks reasonable. Regarding the change to TestLib.pm, we should make
>> sure that the tests have unique names. There is a small amount of
>> duplication currently:
>>
>> ./src/bin/pg
On Thu, Dec 21, 2017 at 10:13 PM, Andrew Dunstan
wrote:
> Looks reasonable. Regarding the change to TestLib.pm, we should make
> sure that the tests have unique names. There is a small amount of
> duplication currently:
>
> ./src/bin/pg_dump/t/001_basic.pl
> ./src/bin/pg_rewind/t/001_basic
On 12/20/2017 09:50 PM, Tom Lane wrote:
> Christoph Berg writes:
>> Re: Tom Lane 2017-12-16 <417.1513438...@sss.pgh.pa.us>
>>> I think we're talking at cross-purposes. I'm not saying we should not fix
>>> this problem. I'm saying that the proposed fix appears incomplete ...
>> Grepping through
Christoph Berg writes:
> Re: Tom Lane 2017-12-16 <417.1513438...@sss.pgh.pa.us>
>> I think we're talking at cross-purposes. I'm not saying we should not fix
>> this problem. I'm saying that the proposed fix appears incomplete ...
> Grepping through the source, there are three places where $0 pr
Re: Tom Lane 2017-12-16 <417.1513438...@sss.pgh.pa.us>
> I think we're talking at cross-purposes. I'm not saying we should not fix
> this problem. I'm saying that the proposed fix appears incomplete, which
> means that (a) even if it solves your problem, it probably does not solve
> related probl
13 matches
Mail list logo
