Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > Looks reasonable. Regarding the change to TestLib.pm, we should make > sure that the tests have unique names. There is a small amount of > duplication currently:
> ./src/bin/pg_dump/t/001_basic.pl > ./src/bin/pg_rewind/t/001_basic.pl > ./src/test/modules/commit_ts/t/001_base.pl > ./src/test/modules/test_pg_dump/t/001_base.pl Perhaps, but that's a separate/pre-existing problem no? The point of the change in my patch was just to avoid getting different behavior in a VPATH build. regards, tom lane