On 2022/07/26 9:42, Kyotaro Horiguchi wrote:
At Sun, 24 Jul 2022 22:40:16 -0400, Tom Lane wrote in
Fujii Masao writes:
On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
I believed that it is recommended to move to the style not having the
outmost parens. That style has been introduced by e3a
At Sun, 24 Jul 2022 22:40:16 -0400, Tom Lane wrote in
> Fujii Masao writes:
> > On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
> >> I believed that it is recommended to move to the style not having the
> >> outmost parens. That style has been introduced by e3a87b4991.
>
> > I read the commit lo
On Thu, Jul 21, 2022 at 11:24 AM Kyotaro Horiguchi
wrote:
>
> > > May be unrelated, IIRC, for the errors like ereport(PANIC,
> > > (errmsg("could not locate a valid checkpoint record"))); we wanted to
> > > add a hint asking users to consider running pg_resetwal to fix the
> > > issue. The error f
Fujii Masao writes:
> On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
>> I believed that it is recommended to move to the style not having the
>> outmost parens. That style has been introduced by e3a87b4991.
> I read the commit log, but I'm not sure yet if it's really recommended to
> remove extr
On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
I believed that it is recommended to move to the style not having the
outmost parens. That style has been introduced by e3a87b4991.
I read the commit log, but I'm not sure yet if it's really recommended to
remove extra parens even from the exis
(errmsg("invalid checkpoint record")));
> > Is it useful to show the specified LSN there?
>
> Yes, LSN info would be helpful also for debugging.
>
> I separated the patch into two; one is to remove useless arguments in
> ReadCheckpointRecord(), anot
At Thu, 21 Jul 2022 23:10:04 -0400, Tom Lane wrote in
> Fujii Masao writes:
> > On 2022/07/21 14:54, Kyotaro Horiguchi wrote:
> >> At Thu, 21 Jul 2022 11:45:23 +0900, Fujii Masao
> >> wrote in
> >>> - (errmsg("could not locate required checkpoint record"),
> >>> + (errmsg("could not locate a v
Fujii Masao writes:
> On 2022/07/21 14:54, Kyotaro Horiguchi wrote:
>> At Thu, 21 Jul 2022 11:45:23 +0900, Fujii Masao
>> wrote in
>>> - (errmsg("could not locate required checkpoint record"),
>>> + (errmsg("could not locate a valid checkpoint record in backup_label
>>> file"),
>> "in back
(errmsg("invalid checkpoint record")));
Is it useful to show the specified LSN there?
Yes, LSN info would be helpful also for debugging.
I separated the patch into two; one is to remove useless arguments in
ReadCheckpointReco
I agree to removing the two parameters. And agree to let
ReadCheckpointRecord not conscious of the location source.
At Thu, 21 Jul 2022 11:45:23 +0900, Fujii Masao
wrote in
> Agreed. Attached is the updated version of the patch.
> Thanks for the review!
- (errmsg("could not locate requir
rs
NTT DATA CORPORATIONFrom a5e45acb753e9d93074a25a2fc409c693c46630c Mon Sep 17 00:00:00 2001
From: Fujii Masao
Date: Wed, 20 Jul 2022 23:06:44 +0900
Subject: [PATCH] Remove useless arguments in ReadCheckpointRecord().
---
src/backend/access/transam/xlogrecovery.c | 88 +-
On Wed, Jul 20, 2022 at 8:21 PM Fujii Masao wrote:
>
> Hi,
>
> I'd like to propose to remove "whichChkpt" and "report" arguments in
> ReadCheckpointRecord(). "report" is obviously useless because it's always
> true, i.e., there are two callers of the function and they always specify
> true as "
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONFrom a33e557a18cf5c45bbcf47f1cf92e26998f1cd67 Mon Sep 17 00:00:00 2001
From: Fujii Masao
Date: Wed, 20 Jul 2022 23:06:44 +0900
Subject: [PATCH] Remove useless arguments in ReadCheckpointRecord().
---
13 matches
Mail list logo
