Re: Remove support for old realpath() API

2024-08-12 Thread Thomas Munro
On Tue, Aug 13, 2024 at 2:35 AM Tom Lane wrote: > I can confirm that the attached program works on cfarm111 (AIX 7.1) > and cfarm119 (AIX 7.3), though "man realpath" denies it on both > systems. Another example of this phenomenon: they have nl_langinfo_l(), a POSIX 2008 feature we want in a nearb

Re: Remove support for old realpath() API

2024-08-12 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> Tom had tested this on and found that it does actually work on AIX 7.1 >> and 7.3 but the documentation is wrong. > I too have a distinct recollection of having tested this (using the > gcc compile farm machines), but I cannot find anything saying so in > t

Re: Remove support for old realpath() API

2024-08-12 Thread Tom Lane
Peter Eisentraut writes: > On 12.08.24 08:47, Thomas Munro wrote: >> I checked this in the AIX 7.3 manual and the POSIX 2008 way does not >> appear to be mentioned there: >> https://www.ibm.com/docs/en/aix/7.3?topic=r-realpath-subroutine > Tom had tested this on and found that it does actually wo

Re: Remove support for old realpath() API

2024-08-12 Thread Peter Eisentraut
On 12.08.24 08:47, Thomas Munro wrote: On Mon, Aug 12, 2024 at 6:18 PM Peter Eisentraut wrote: On 05.08.24 09:41, Heikki Linnakangas wrote: On 05/08/2024 09:12, Peter Eisentraut wrote: The now preferred way to call realpath() is by passing NULL as the second argument and get a malloc'ed resul

Re: Remove support for old realpath() API

2024-08-11 Thread Thomas Munro
On Mon, Aug 12, 2024 at 6:18 PM Peter Eisentraut wrote: > On 05.08.24 09:41, Heikki Linnakangas wrote: > > On 05/08/2024 09:12, Peter Eisentraut wrote: > >> The now preferred way to call realpath() is by passing NULL as the > >> second argument and get a malloc'ed result. We still supported the >

Re: Remove support for old realpath() API

2024-08-11 Thread Peter Eisentraut
On 05.08.24 09:41, Heikki Linnakangas wrote: On 05/08/2024 09:12, Peter Eisentraut wrote: The now preferred way to call realpath() is by passing NULL as the second argument and get a malloc'ed result.  We still supported the old way of providing our own buffer as a second argument, for some plat

Re: Remove support for old realpath() API

2024-08-06 Thread Daniel Gustafsson
> On 6 Aug 2024, at 07:43, Michael Paquier wrote: > I am dubious that it is a good idea to remove > this code knowing that we have a thread from a few months ago about > the fact that we have folks complaining about AIX support and that we > should bring it back: According to upthread it is supp

Re: Remove support for old realpath() API

2024-08-05 Thread Michael Paquier
On Mon, Aug 05, 2024 at 10:08:04AM -0400, Tom Lane wrote: > Heikki Linnakangas writes: >> We don't seem to have any mentions of POSIX or SuS in docs, in the >> installation sections. There are a few mentions of POSIX-1.2008 and >> POSIX-1.2001 it in the commit log, though, where we require featu

Re: Remove support for old realpath() API

2024-08-05 Thread Tom Lane
Heikki Linnakangas writes: > We don't seem to have any mentions of POSIX or SuS in docs, in the > installation sections. There are a few mentions of POSIX-1.2008 and > POSIX-1.2001 it in the commit log, though, where we require features > specified by those. Can we rely on everything from POSIX

Re: Remove support for old realpath() API

2024-08-05 Thread Heikki Linnakangas
On 05/08/2024 09:12, Peter Eisentraut wrote: The now preferred way to call realpath() is by passing NULL as the second argument and get a malloc'ed result.  We still supported the old way of providing our own buffer as a second argument, for some platforms that didn't support the new way yet.  Th

Remove support for old realpath() API

2024-08-04 Thread Peter Eisentraut
07:50:27 +0200 Subject: [PATCH] Remove support for old realpath() API The now preferred way to call realpath() is by passing NULL as the second argument and get a malloc'ed result. We still supported the old way of providing our own buffer as a second argument, for some platforms that didn'