Re: Recent failures on buildfarm member hornet

2020-10-07 Thread Noah Misch
On Wed, Oct 07, 2020 at 06:22:04PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Wed, Oct 07, 2020 at 06:03:16PM -0400, Tom Lane wrote: > >> After thinking about it a bit more, I'm not even convinced that what > >> xlc seems to be doing is illegal per C spec. There are no sequence > >> point

Re: Recent failures on buildfarm member hornet

2020-10-07 Thread Tom Lane
Noah Misch writes: > On Wed, Oct 07, 2020 at 06:03:16PM -0400, Tom Lane wrote: >> After thinking about it a bit more, I'm not even convinced that what >> xlc seems to be doing is illegal per C spec. There are no sequence >> points within >> >> return list_make2(list_concat(directargs, ordere

Re: Recent failures on buildfarm member hornet

2020-10-07 Thread Noah Misch
On Wed, Oct 07, 2020 at 06:03:16PM -0400, Tom Lane wrote: > I wrote: > > I'm tempted to propose the attached small code rearrangement, which > > might dissuade the compiler from thinking it can get away with this. That patch does get hornet's -O2 build to again pass "make check". It doesn't harm

Re: Recent failures on buildfarm member hornet

2020-10-07 Thread Tom Lane
I wrote: > I'm tempted to propose the attached small code rearrangement, which > might dissuade the compiler from thinking it can get away with this. > While I concur with your point that an old xlc version might not be > that exciting, there could be other compilers doing the same thing > in the f

Re: Recent failures on buildfarm member hornet

2020-10-07 Thread Tom Lane
Noah Misch writes: > On Thu, Oct 08, 2020 at 09:15:12AM +1300, David Rowley wrote: >> It would be interesting to see gram.s from both cc99baa4~1 and cc99baa4. > Attached. Both generated like this: Hm. I'm too lazy to go bone up on PPC64 ABI conventions, but this does look suspiciously like the

Re: Recent failures on buildfarm member hornet

2020-10-07 Thread David Rowley
Thanks for investigating this, Noah. On Thu, 8 Oct 2020 at 06:13, Tom Lane wrote: > > Noah Misch writes: > > gram.o was it. (The way I rebuilt gram.o also rebuilt parser.o and scan.o, > > but those seem far less likely.) > > This suggests that the problem is misoptimization of gram.y's > makeOr

Re: Recent failures on buildfarm member hornet

2020-10-07 Thread Tom Lane
Noah Misch writes: > On Tue, Oct 06, 2020 at 09:56:49PM -0400, Tom Lane wrote: >> Now that *is* surprising. Could you poke a little further to determine >> which module is getting miscompiled? (gram.o seems like the next most >> likely bet.) > gram.o was it. (The way I rebuilt gram.o also rebu

Re: Recent failures on buildfarm member hornet

2020-10-06 Thread Noah Misch
On Tue, Oct 06, 2020 at 09:56:49PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Mon, Oct 05, 2020 at 08:42:15PM -0400, Tom Lane wrote: > >> hornet has failed its last five runs with > >> TRAP: FailedAssertion("variadicArgType != InvalidOid", File: > >> "pg_aggregate.c", Line: 216, PID: 3473

Re: Recent failures on buildfarm member hornet

2020-10-06 Thread Tom Lane
Noah Misch writes: > On Mon, Oct 05, 2020 at 08:42:15PM -0400, Tom Lane wrote: >> hornet has failed its last five runs with >> TRAP: FailedAssertion("variadicArgType != InvalidOid", File: >> "pg_aggregate.c", Line: 216, PID: 34734498) > Building the tree with -O0 suppresses the problem. (xlc do

Re: Recent failures on buildfarm member hornet

2020-10-06 Thread Noah Misch
On Mon, Oct 05, 2020 at 08:42:15PM -0400, Tom Lane wrote: > hornet has failed its last five runs with > > 2020-10-05 22:45:42.784 UTC [34734498:40] pg_regress/create_aggregate LOG: > statement: create aggregate my_percentile_disc(float8 ORDER BY anyelement) ( > stype = internal, >

Recent failures on buildfarm member hornet

2020-10-05 Thread Tom Lane
hornet has failed its last five runs with 2020-10-05 22:45:42.784 UTC [34734498:40] pg_regress/create_aggregate LOG: statement: create aggregate my_percentile_disc(float8 ORDER BY anyelement) ( stype = internal, sfunc = ordered_set_transition, finalfunc = percentile