On Sat, Aug 27, 2022 at 2:23 PM Andres Freund wrote:
>
> Hi,
>
> On 2022-08-27 12:53:24 +0700, John Naylor wrote:
> > Update: I tried taking the CI for a spin, but ran into IT issues with
> > Github when I tried to push my branch to remote.
>
> A github, not a CI issue? Just making sure...
Yeah,
Hi,
On 2022-08-27 12:53:24 +0700, John Naylor wrote:
> On Sat, Aug 27, 2022 at 11:20 AM John Naylor
> wrote:
> >
> > Here's a patch with that idea, not tested on Windows yet.
>
> Update: I tried taking the CI for a spin, but ran into IT issues with
> Github when I tried to push my branch to remo
On 2022-08-26 23:02:06 -0400, Tom Lane wrote:
> John Naylor writes:
> > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
> >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
> >> include in plperl.h would keep that aspect transparent, because
> >> plperl_utils.h
>
On Sat, Aug 27, 2022 at 11:20 AM John Naylor
wrote:
>
> Here's a patch with that idea, not tested on Windows yet.
Update: I tried taking the CI for a spin, but ran into IT issues with
Github when I tried to push my branch to remote.
--
John Naylor
EDB: http://www.enterprisedb.com
On Sat, Aug 27, 2022 at 10:02 AM Tom Lane wrote:
>
> John Naylor writes:
> > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
> >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
> >> include in plperl.h would keep that aspect transparent, because
> >> plperl_uti
John Naylor writes:
> On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
>> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
>> include in plperl.h would keep that aspect transparent, because
>> plperl_utils.h
>> includes plperl.h.
> Since plperl_helpers.h already i
On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote:
> > On 2022-08-26 Fr 10:47, Andres Freund wrote:
> > > Given the crazy defines of stuff like free, it seems like a good idea to
> > > have
> > > a rule that no headers should be in
Hi,
On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote:
> On 2022-08-26 Fr 10:47, Andres Freund wrote:
> > Given the crazy defines of stuff like free, it seems like a good idea to
> > have
> > a rule that no headers should be included after plperl.h with
> > PG_NEED_PERL_XSUB_H defined. It's not
On 2022-08-26 Fr 10:47, Andres Freund wrote:
> Hi,
>
> On 2022-08-26 21:39:05 +0700, John Naylor wrote:
>> On Fri, Aug 26, 2022 at 9:27 PM Andres Freund wrote:
>>> Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
>>> causes issues when including system headers referen
Andres Freund writes:
> Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
> you have a better suggestion than moving the mb/pg_wchar.h include out of
> plperl_helpers.h as I suggest below?
I agree with the conclusion that we'd better #include all our own
headers before
Hi,
Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
you have a better suggestion than moving the mb/pg_wchar.h include out of
plperl_helpers.h as I suggest below?
On 2022-08-26 07:47:40 -0700, Andres Freund wrote:
> On 2022-08-26 21:39:05 +0700, John Naylor wrote:
>
Hi,
On 2022-08-26 21:39:05 +0700, John Naylor wrote:
> On Fri, Aug 26, 2022 at 9:27 PM Andres Freund wrote:
> >
> > Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> > causes issues when including system headers referencing free as well.
> >
> > I don't really see a g
On Fri, Aug 26, 2022 at 9:27 PM Andres Freund wrote:
>
> Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> causes issues when including system headers referencing free as well.
>
> I don't really see a good solution to this other than hoisting the
> mb/pg_wchar.h inclu
Hi,
On 2022-08-26 06:40:47 -0700, Andres Freund wrote:
> On 2022-08-26 06:21:51 -0700, Andres Freund wrote:
> > On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> > > The last 20 some consecutive builds failed:
> > > https://cirrus-ci.com/github/postgresql-cfbot/postgresql
> > >
> > > like this
Hi,
On 2022-08-26 06:21:51 -0700, Andres Freund wrote:
> On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> > The last 20 some consecutive builds failed:
> > https://cirrus-ci.com/github/postgresql-cfbot/postgresql
> >
> > like this:
> > [09:29:27.711] C:\Program Files (x86)\Windows
> > Kits\1
Hi,
On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> The last 20 some consecutive builds failed:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql
>
> like this:
> [09:29:27.711] C:\Program Files (x86)\Windows
> Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_pe
16 matches
Mail list logo
