On 2022-08-26 23:02:06 -0400, Tom Lane wrote: > John Naylor <john.nay...@enterprisedb.com> writes: > > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <and...@anarazel.de> wrote: > >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the > >> include in plperl.h would keep that aspect transparent, because > >> plperl_utils.h > >> includes plperl.h. > > > Since plperl_helpers.h already includes plperl.h, I'm not sure why > > both are included everywhere the former is. If .c/.xs files didn't > > include plperl.h directly, we could keep pg_wchar.h in > > plperl_helpers.h. Not sure if that's workable or any better... > > Maybe we should flush the separate plperl_helpers.h header and just > put those static-inline functions in plperl.h.
+1
