Re: valgrind error

2020-06-06 Thread Tom Lane
I wrote: > Noah Misch writes: >> Apparently, valgrind-3.15.0 doesn't complain about undefined input >> to _mm_crc32_u* functions. We should not be surprised if Valgrind gains the >> features necessary to complain about the other implementations. > Perhaps it already has ... I wonder if anyone's

Re: valgrind error

2020-06-05 Thread Tom Lane
Noah Misch writes: > On Fri, Jun 05, 2020 at 12:17:54PM -0400, Tom Lane wrote: >> as you have it, I'd prefer to use >> - fun:pg_comp_crc32c >> + fun:pg_comp_crc32c_sb8 >> which precisely matches what 4f700bc did. The other way seems like >> it's giving a free pass to problems that cou

Re: valgrind error

2020-06-05 Thread Noah Misch
On Fri, Jun 05, 2020 at 12:17:54PM -0400, Tom Lane wrote: > Noah Misch writes: > > I can reproduce this on a 2017-vintage CPU with ./configure > > ... USE_SLICING_BY_8_CRC32C=1 and then running "make installcheck-parallel" > > under valgrind-3.15.0 (as packaged by RHEL 7.8). valgrind.supp has a >

Re: valgrind error

2020-06-05 Thread Tom Lane
Noah Misch writes: > I can reproduce this on a 2017-vintage CPU with ./configure > ... USE_SLICING_BY_8_CRC32C=1 and then running "make installcheck-parallel" > under valgrind-3.15.0 (as packaged by RHEL 7.8). valgrind.supp has a > suppression for CRC calculations, but it didn't get the memo when

Re: valgrind error

2020-06-05 Thread Noah Misch
On Sun, May 10, 2020 at 09:29:05AM -0400, Andrew Dunstan wrote: > On 4/18/20 9:15 AM, Andrew Dunstan wrote: > > I was just trying to revive lousyjack, my valgrind buildfarm animal > > which has been offline for 12 days, after having upgraded the machine > > (fedora 31, gcc 9.3.1, valgrind 3.15) and

Re: valgrind error

2020-05-10 Thread Andrew Dunstan
On 4/18/20 9:15 AM, Andrew Dunstan wrote: > I was just trying to revive lousyjack, my valgrind buildfarm animal > which has been offline for 12 days, after having upgraded the machine > (fedora 31, gcc 9.3.1, valgrind 3.15) and noticed lots of errors like this: > > > 2020-04-17 19:26:03.483 EDT [