Noah Misch <n...@leadboat.com> writes:
> On Fri, Jun 05, 2020 at 12:17:54PM -0400, Tom Lane wrote:
>> as you have it, I'd prefer to use
>> - fun:pg_comp_crc32c
>> + fun:pg_comp_crc32c_sb8
>> which precisely matches what 4f700bc did. The other way seems like
>> it's giving a free pass to problems that could lurk in unrelated CRC
>> implementations.
> The undefined data is in the CRC input, namely the padding bytes in xl_*
> structs.
Oh, I see. Objection withdrawn.
> Apparently, valgrind-3.15.0 doesn't complain about undefined input
> to _mm_crc32_u* functions. We should not be surprised if Valgrind gains the
> features necessary to complain about the other implementations.
Perhaps it already has ... I wonder if anyone's tried this on ARMv8
lately.
regards, tom lane
