Re: typo fix in pgstat.c: "exits should be exists"

2021-04-05 Thread vignesh C
On Tue, Apr 6, 2021 at 10:41 AM Fujii Masao wrote: > > > > On 2021/04/06 13:57, vignesh C wrote: > > Hi, > > > > While reviewing replication statistics I found a small typo. Attached > > patch for a typo in: > > src/backend/postmaster/pgstat.c > > Thanks for the report and patch! Pushed. > Thanks

Re: typo fix in pgstat.c: "exits should be exists"

2021-04-05 Thread Fujii Masao
On 2021/04/06 13:57, vignesh C wrote: Hi, While reviewing replication statistics I found a small typo. Attached patch for a typo in: src/backend/postmaster/pgstat.c Thanks for the report and patch! Pushed. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Developme

Re: typo fix

2018-11-19 Thread Amit Langote
On 2018/11/20 15:58, Tom Lane wrote: > Michael Paquier writes: >> On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: >>> - * We also use EquivalenceClasses as the base structure for PathKeys, >>> letting >>> + * We also use EquivalenceClass as the base structure for PathKeys, letting >

Re: typo fix

2018-11-19 Thread Michael Paquier
On Tue, Nov 20, 2018 at 01:58:22AM -0500, Tom Lane wrote: > The reason that's not good is that it creates a singular-plural mismatch. > If you'd also changed "PathKeys" to "PathKey", it would still read OK, > though I don't think it's an improvement particularly. > > (Hm ... though arguably, "stru

Re: typo fix

2018-11-19 Thread Tom Lane
Michael Paquier writes: > On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: >> - * We also use EquivalenceClasses as the base structure for PathKeys, >> letting >> + * We also use EquivalenceClass as the base structure for PathKeys, letting > ... But not that. The reason that's not

Re: typo fix

2018-11-19 Thread Amit Langote
Thank you for looking. On 2018/11/20 14:13, Michael Paquier wrote: > On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: >> It seems to me that EquivalenceClass, the struct/type name, has been >> misspelled as 'EquivalenceClasses' a couple of times in the comment above >> its definition.

Re: typo fix

2018-11-19 Thread Michael Paquier
On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: > It seems to me that EquivalenceClass, the struct/type name, has been > misspelled as 'EquivalenceClasses' a couple of times in the comment above > its definition. EquivalenceClasses stands for the plural of EquivalenceClass. So think