Re: trivial improvement to system_or_bail

2021-07-07 Thread Daniel Gustafsson
> On 6 Jul 2021, at 23:59, Alvaro Herrera wrote: > Failures now look like this, respectively: > > Bailout called. Further testing stopped: failed to execute command "finitdb > -D > /home/alvherre/Code/pgsql-build/master/src/test/recovery/tmp_check/t_019_replslot_limit_primary_data/pgdata >

Re: trivial improvement to system_or_bail

2021-07-06 Thread Alvaro Herrera
On 2021-Jun-30, Daniel Gustafsson wrote: > + BAIL_OUT("system $_[0] failed: $!\n"); > I wonder if we should take more inspiration from the Perl manual and change it > to "failed to execute" to make it clear that the failure was in executing the > program, not from the program i

Re: trivial improvement to system_or_bail

2021-06-30 Thread Tom Lane
Alvaro Herrera writes: > When PostgresNode::system_or_bail() fails, it's quite opaque as to what > is happening. This patch improves things by printing some detail, as > suggested in Perl's doc for system(). +1 for adding the extra details, but another thing that I've always found very confusing

Re: trivial improvement to system_or_bail

2021-06-30 Thread Daniel Gustafsson
> On 30 Jun 2021, at 17:24, Alvaro Herrera wrote: > > When PostgresNode::system_or_bail() fails, it's quite opaque as to what > is happening. This patch improves things by printing some detail, as > suggested in Perl's doc for system(). +1 on this from reading the patch. +