Re: some unused parameters cleanup

2020-08-26 Thread Tom Lane
Peter Eisentraut writes: > On 2020-08-25 18:59, Tom Lane wrote: >> For some of these, there's an argument for keeping the unused parameter >> for consistency with sibling functions that do use it. Not sure how >> important that is, though. > I had meant to exclude cases like this from this patch

Re: some unused parameters cleanup

2020-08-26 Thread Michael Paquier
On Wed, Aug 26, 2020 at 06:38:52AM +0200, Peter Eisentraut wrote: > I had meant to exclude cases like this from this patch set. If you see a > case like this in *this* patch set, please point it out. Last time I looked at that a lot of parameters are kept around as a matter of symmetry with sibli

Re: some unused parameters cleanup

2020-08-25 Thread Peter Eisentraut
On 2020-08-25 18:59, Tom Lane wrote: Peter Eisentraut writes: Here is a series of patches to remove some unused function parameters. In each case, the need for them was removed by some other code changes over time but the unusedness was not noticed. I have included a reference to when they bec

Re: some unused parameters cleanup

2020-08-25 Thread Fujii Masao
On 2020/08/26 2:50, Andreas Karlsson wrote: On 8/25/20 7:42 PM, Bruce Momjian wrote: On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote: Peter Eisentraut writes: Here is a series of patches to remove some unused function parameters. In each case, the need for them was removed by some

Re: some unused parameters cleanup

2020-08-25 Thread Andreas Karlsson
On 8/25/20 7:42 PM, Bruce Momjian wrote: On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote: Peter Eisentraut writes: Here is a series of patches to remove some unused function parameters. In each case, the need for them was removed by some other code changes over time but the unusedness

Re: some unused parameters cleanup

2020-08-25 Thread Bruce Momjian
On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > Here is a series of patches to remove some unused function parameters. > > In each case, the need for them was removed by some other code changes > > over time but the unusedness was not noticed. I have inc

Re: some unused parameters cleanup

2020-08-25 Thread Tom Lane
Peter Eisentraut writes: > Here is a series of patches to remove some unused function parameters. > In each case, the need for them was removed by some other code changes > over time but the unusedness was not noticed. I have included a > reference to when they became unused in each case. For