Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > On 2020-08-25 18:59, Tom Lane wrote: >> For some of these, there's an argument for keeping the unused parameter >> for consistency with sibling functions that do use it. Not sure how >> important that is, though.
> I had meant to exclude cases like this from this patch set. If you see > a case like this in *this* patch set, please point it out. I'd been thinking specifically of the changes in pg_backup_archiver.c. But now that I look around a bit further, there's already very little consistency in that file about whether to pass the ArchiveHandle* pointer everywhere. So no further objection here. regards, tom lane