Re: setLastTid() and currtid()

2020-10-15 Thread Michael Paquier
On Tue, Oct 13, 2020 at 02:12:53PM -0400, Bruce Momjian wrote: > Where are we on this? Can the functions be removed in PG 14? (Sent this message previously but it got lost after some cross-posting across two lists, issue fixed now.) I still have a patch lying around to do that, registered in the

Re: setLastTid() and currtid()

2020-10-13 Thread Bruce Momjian
On Fri, Feb 7, 2020 at 05:24:12PM +0900, Fujii Masao wrote: > On Fri, Apr 12, 2019 at 1:44 PM Michael Paquier wrote: > > > > On Thu, Apr 11, 2019 at 02:06:13PM -0400, Tom Lane wrote: > > > Yeah, if we could simplify the tableam API, that would be sufficient > > > reason to remove the stuff in v12

Re: setLastTid() and currtid()

2020-02-07 Thread Fujii Masao
On Fri, Apr 12, 2019 at 1:44 PM Michael Paquier wrote: > > On Thu, Apr 11, 2019 at 02:06:13PM -0400, Tom Lane wrote: > > Yeah, if we could simplify the tableam API, that would be sufficient > > reason to remove the stuff in v12, IMO. But if it is outside of that > > API, I'd counsel waiting till

Re: setLastTid() and currtid()

2019-04-11 Thread Michael Paquier
On Thu, Apr 11, 2019 at 02:06:13PM -0400, Tom Lane wrote: > Yeah, if we could simplify the tableam API, that would be sufficient > reason to remove the stuff in v12, IMO. But if it is outside of that > API, I'd counsel waiting till v13. Yes, I agree that simplifying the table AM interface would b

Re: setLastTid() and currtid()

2019-04-11 Thread Tom Lane
Andres Freund writes: > On 2019-04-11 13:27:03 -0400, Tom Lane wrote: >> I think removing it after feature freeze is not something to do, >> but +1 for nuking it as soon as the v13 branch opens. Unless >> there's some important reason we need it to be gone in v12? > No, I don't think there reall

Re: setLastTid() and currtid()

2019-04-11 Thread Andres Freund
Hi, On 2019-04-11 13:52:08 -0400, Alvaro Herrera wrote: > As I understand, this setLastTid stuff would cause trouble if used > with a non-core table AM. I'm not sure there'd actually be trouble. I mean, what it does for heap is basically meaningless already, so it's not going to be meaningfully w

Re: setLastTid() and currtid()

2019-04-11 Thread Alvaro Herrera
On 2019-Apr-11, Tom Lane wrote: > Andres Freund writes: > > On 2019-03-27 10:01:08 +0900, Inoue, Hiroshi wrote: > >> The above code remains only for PG servers whose version < 8.2. > >> Please remove the code around setLastTid(). > > > Does anybody else have concerns about removing this interfac

Re: setLastTid() and currtid()

2019-04-11 Thread Andres Freund
Hi, On 2019-04-11 13:27:03 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-03-27 10:01:08 +0900, Inoue, Hiroshi wrote: > >> The above code remains only for PG servers whose version < 8.2. > >> Please remove the code around setLastTid(). > > > Does anybody else have concerns about remo

Re: setLastTid() and currtid()

2019-04-11 Thread Tom Lane
Andres Freund writes: > On 2019-03-27 10:01:08 +0900, Inoue, Hiroshi wrote: >> The above code remains only for PG servers whose version < 8.2. >> Please remove the code around setLastTid(). > Does anybody else have concerns about removing this interface? Does > anybody think we should have a depr

Re: setLastTid() and currtid()

2019-04-11 Thread Andres Freund
Hi, On 2019-03-27 10:01:08 +0900, Inoue, Hiroshi wrote: > Hi Andres, > Sorry for the late reply. Not late at all. Sorry for *my* late reply :) > On 2019/03/26 9:44, Andres Freund wrote: > > Hi, > > > > For the tableam work I'd like to remove heapam.h from > > nodeModifyTable.c. The only remain

Re: setLastTid() and currtid()

2019-03-26 Thread Inoue, Hiroshi
Hi Andres, Sorry for the late reply. On 2019/03/26 9:44, Andres Freund wrote: Hi, For the tableam work I'd like to remove heapam.h from nodeModifyTable.c. The only remaining impediment to that is a call to setLastTid(), which is defined in tid.c but declared in heapam.h. That doesn't seem like