On 2019-Apr-11, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2019-03-27 10:01:08 +0900, Inoue, Hiroshi wrote: > >> The above code remains only for PG servers whose version < 8.2. > >> Please remove the code around setLastTid(). > > > Does anybody else have concerns about removing this interface? Does > > anybody think we should have a deprecation phase? Should we remove this > > in 12 or 13? > > I think removing it after feature freeze is not something to do, > but +1 for nuking it as soon as the v13 branch opens. Unless > there's some important reason we need it to be gone in v12?
Umm ... I'm not sure I agree. We're in feature freeze, not code freeze, and while we're not expecting to have any new feature patches pushed, cleanup for features that did make the cut is still fair game. As I understand, this setLastTid stuff would cause trouble if used with a non-core table AM. Furthermore, if nothing uses it, what's the point of keeping it? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
