Re: reorder pg_rewind control file sync

2019-03-25 Thread Michael Paquier
On Mon, Mar 25, 2019 at 10:29:46AM +0100, Fabien COELHO wrote: > I have run the non regression tests. I'm not sure of what scenarii are > covered there, but probably not an interruption in the middle of a fsync, > specially if fsync is usually disabled to ease the tests:-) Force the tool to stop a

Re: reorder pg_rewind control file sync

2019-03-25 Thread Fabien COELHO
Bonjour Michaƫl, The attached patch reorders the cluster fsyncing and control file changes in "pg_rewind" so that the later is done after all data are committed to disk, so as to reflect the actual cluster status, similarly to what is done by "pg_checksums", per discussion in the thread about o

Re: reorder pg_rewind control file sync

2019-03-25 Thread Michael Paquier
On Sat, Mar 23, 2019 at 06:18:27AM +0100, Fabien COELHO wrote: > Here it is. Thanks. > The attached patch reorders the cluster fsyncing and control file changes in > "pg_rewind" so that the later is done after all data are committed to disk, > so as to reflect the actual cluster status, similarly