Re: refactor ownercheck and aclcheck functions

2022-11-13 Thread Peter Eisentraut
On 09.11.22 19:12, Corey Huinker wrote: After considering this again, I decided to brute-force this and get rid of all the trivial wrapper functions and also several of the special cases.  That way, there is less confusion at the call sites about why this or that style is used in

Re: refactor ownercheck and aclcheck functions

2022-11-09 Thread Corey Huinker
> > After considering this again, I decided to brute-force this and get rid > of all the trivial wrapper functions and also several of the special > cases. That way, there is less confusion at the call sites about why > this or that style is used in a particular case. Also, it now makes > sure yo

Re: refactor ownercheck and aclcheck functions

2022-11-07 Thread Antonin Houska
Peter Eisentraut wrote: > These patches take the dozens of mostly-duplicate pg_foo_ownercheck() and > pg_foo_aclcheck() functions and replace (most of) them by common functions > that are driven by the ObjectProperty table. All the required information is > already in that table. > > This is si

Re: refactor ownercheck and aclcheck functions

2022-10-21 Thread Peter Eisentraut
On 20.10.22 01:24, Corey Huinker wrote: I'd be inclined to remove the highly used ones as well. That way the codebase would have more examples of object_ownercheck() for readers to see. Seeing the existence of pg_FOO_ownercheck implies that a pg_BAR_ownercheck might exist, and if BAR is missing

Re: refactor ownercheck and aclcheck functions

2022-10-19 Thread Corey Huinker
On Fri, Oct 14, 2022 at 3:39 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > These patches take the dozens of mostly-duplicate pg_foo_ownercheck() > and pg_foo_aclcheck() functions and replace (most of) them by common > functions that are driven by the ObjectProperty table. All