Peter Eisentraut <peter.eisentr...@enterprisedb.com> wrote: > These patches take the dozens of mostly-duplicate pg_foo_ownercheck() and > pg_foo_aclcheck() functions and replace (most of) them by common functions > that are driven by the ObjectProperty table. All the required information is > already in that table. > > This is similar to the consolidation of the drop-by-OID functions that we did > a while ago (b1d32d3e3230f00b5baba08f75b4f665c7d6dac6).
I've reviewed this patch, as it's related to my patch [1] (In particular, it reduces the size of my patch a little bit). I like the idea to reduce the amount of (almost) copy & pasted code. I haven't found any problem in your patch that would be worth mentioning, except that the 0001 part does not apply to the current master branch. -- Antonin Houska Web: https://www.cybertec-postgresql.com