Re: psql show URL with help

2019-03-11 Thread Peter Eisentraut
On 2019-03-08 16:11, David Fetter wrote: >> The outcome of that is exactly what my patch does, but the inputs are >> different. We have PG_MAJORVERSION, which is always a single integer, >> and PG_VERSION, which could be 10.9.8 or 11beta5 or 12devel. The patch does >> >> if (PG_VERSION ends with

Re: psql show URL with help

2019-03-08 Thread David Fetter
On Fri, Mar 08, 2019 at 01:45:03PM +0100, Peter Eisentraut wrote: > On 2019-03-07 23:02, David Fetter wrote: > >> if (psql_version_is_numeric) > >> return /docs/psql_version/ > >> else if (psql_version ends with 'devel') > >> return /docs/devel/ > >> else > >> return /docs/{psql_version but wi

Re: psql show URL with help

2019-03-08 Thread Peter Eisentraut
On 2019-03-07 23:02, David Fetter wrote: >> if (psql_version_is_numeric) >> return /docs/psql_version/ >> else if (psql_version ends with 'devel') >> return /docs/devel/ >> else >> return /docs/{psql_version but with text stripped}/ >> >> So that e.g. 12beta would return "12", as would 12rc or

Re: psql show URL with help

2019-03-07 Thread David Fetter
On Thu, Mar 07, 2019 at 11:44:07AM -0800, Magnus Hagander wrote: > On Mon, Mar 4, 2019 at 11:41 PM Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > > > On 2019-03-04 17:55, Magnus Hagander wrote: > > > If the first thing we do when we move from devel to some other state > > >

Re: psql show URL with help

2019-03-07 Thread Magnus Hagander
On Mon, Mar 4, 2019 at 11:41 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2019-03-04 17:55, Magnus Hagander wrote: > > If the first thing we do when we move from devel to some other state > > (beta, RC, etc.) is to publish the docs under the major version > > num

Re: psql show URL with help

2019-03-04 Thread Peter Eisentraut
On 2019-03-04 17:55, Magnus Hagander wrote: > If the first thing we do when we move from devel to some other state > (beta, RC, etc.) is to publish the docs under the major version > number, then maybe this test should be more along the lines of looking > for anything that's neither

Re: psql show URL with help

2019-03-04 Thread Magnus Hagander
On Sun, Mar 3, 2019 at 10:48 PM David Fetter wrote: > On Sun, Mar 03, 2019 at 09:57:25PM +0100, Magnus Hagander wrote: > > On Sun, Mar 3, 2019 at 7:14 PM David Fetter wrote: > > > > > On Wed, Feb 27, 2019 at 09:14:59AM +0100, Peter Eisentraut wrote: > > > > +

Re: psql show URL with help

2019-03-03 Thread David Fetter
On Sun, Mar 03, 2019 at 09:57:25PM +0100, Magnus Hagander wrote: > On Sun, Mar 3, 2019 at 7:14 PM David Fetter wrote: > > > On Wed, Feb 27, 2019 at 09:14:59AM +0100, Peter Eisentraut wrote: > > > + url = psprintf(" > > https://www.postgresql.org/docs/%s/%s.html

Re: psql show URL with help

2019-03-03 Thread Magnus Hagander
On Sun, Mar 3, 2019 at 7:14 PM David Fetter wrote: > On Wed, Feb 27, 2019 at 09:14:59AM +0100, Peter Eisentraut wrote: > > + url = psprintf(" > https://www.postgresql.org/docs/%s/%s.html";, > > + > strstr(PG_VERSION, "devel") ? "devel" : PG_MAJORVERSION, > > +

Re: psql show URL with help

2019-03-03 Thread Ramanarayana
Hi, Is there any documentation change required for this patch? Cheers Ram 4.0

Re: psql show URL with help

2019-03-03 Thread David Fetter
On Wed, Feb 27, 2019 at 09:14:59AM +0100, Peter Eisentraut wrote: > + url = > psprintf("https://www.postgresql.org/docs/%s/%s.html";, > + > strstr(PG_VERSION, "devel") ? "devel" : PG_MAJORVERSION, >

Re: psql show URL with help

2019-02-27 Thread Peter Eisentraut
On 2019-02-25 12:05, Peter Eisentraut wrote: > On 2019-02-21 18:28, Peter Eisentraut wrote: >> => \h analyze > >> URL: https://www.postgresql.org/docs/12/sql-analyze.html >> > > Here is a patch. > > It doesn't deal with the "devel" paths yet. Discussion there is still > ongoing a bit. A n

Re: psql show URL with help

2019-02-25 Thread Pavel Stehule
po 25. 2. 2019 v 12:06 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > On 2019-02-22 12:07, Magnus Hagander wrote: > > (Won't actually work because the web site isn't serving "12" URLs > yet, > > but that's something that could probably be sorted out.) > > > > > >

Re: psql show URL with help

2019-02-25 Thread Peter Eisentraut
On 2019-02-22 12:07, Magnus Hagander wrote: > (Won't actually work because the web site isn't serving "12" URLs yet, > but that's something that could probably be sorted out.) > > > Why not just link to /devel/ when it's a devel version? The 12 docs will > be up alongside the first beta v

Re: psql show URL with help

2019-02-25 Thread Peter Eisentraut
On 2019-02-21 18:28, Peter Eisentraut wrote: > => \h analyze > URL: https://www.postgresql.org/docs/12/sql-analyze.html > Here is a patch. It doesn't deal with the "devel" paths yet. Discussion there is still ongoing a bit. -- Peter Eisentraut http://www.2ndQuadrant.com/ Pos

Re: psql show URL with help

2019-02-22 Thread Tom Lane
Euler Taveira writes: > I'm not suggesting that we replace version number using the latest > version URL. However, we could prevent URL to be shown if the version > mismatch. If psql wasn't backward compatible we shouldn't care but it > is. Someone could be confused as I said earlier. I tend to a

Re: psql show URL with help

2019-02-22 Thread Euler Taveira
Em sex, 22 de fev de 2019 às 11:55, Tom Lane escreveu: > > The syntax summary that psql is showing is for its own version, and > I'd say the URL must be too. You can't even be sure that a corresponding > URL would exist in another version, so blindly inserting the server's > major version into a

Re: psql show URL with help

2019-02-22 Thread Tom Lane
Euler Taveira writes: > Em qui, 21 de fev de 2019 às 14:28, Peter Eisentraut > escreveu: >> URL: https://www.postgresql.org/docs/12/sql-analyze.html > What happen if I connect to an old server? Did it print URL according > to psql version or server version? psql prints help about its version > a

Re: psql show URL with help

2019-02-22 Thread Peter Eisentraut
On 2019-02-22 15:37, Euler Taveira wrote: > Em qui, 21 de fev de 2019 às 14:28, Peter Eisentraut > escreveu: >> URL: https://www.postgresql.org/docs/12/sql-analyze.html >> >> > What happen if I connect to an old server? Did it print URL according > to psql version or server version? psql prin

Re: psql show URL with help

2019-02-22 Thread Euler Taveira
Em qui, 21 de fev de 2019 às 14:28, Peter Eisentraut escreveu: > > URL: https://www.postgresql.org/docs/12/sql-analyze.html > > What happen if I connect to an old server? Did it print URL according to psql version or server version? psql prints help about its version and if user wants details

Re: psql show URL with help

2019-02-22 Thread Magnus Hagander
On Thu, Feb 21, 2019 at 6:28 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > As mentioned on > > > https://www.cybertec-postgresql.com/en/looking-at-mysql-8-with-postgresql-goggles-on/ > > how about this: > > => \h analyze > Command: ANALYZE > Description: collect statistics a

Re: psql show URL with help

2019-02-21 Thread David Fetter
On Thu, Feb 21, 2019 at 06:28:09PM +0100, Peter Eisentraut wrote: > As mentioned on > > https://www.cybertec-postgresql.com/en/looking-at-mysql-8-with-postgresql-goggles-on/ > > how about this: > > => \h analyze > Command: ANALYZE > Description: collect statistics about a database > Syntax:

Re: psql show URL with help

2019-02-21 Thread Julien Rouhaud
On Thu, Feb 21, 2019 at 6:33 PM Pavel Stehule wrote: > > čt 21. 2. 2019 v 18:28 odesílatel Peter Eisentraut > napsal: >> >> As mentioned on >> >> https://www.cybertec-postgresql.com/en/looking-at-mysql-8-with-postgresql-goggles-on/ >> >> how about this: >> >> => \h analyze >> Command: ANALYZ

Re: psql show URL with help

2019-02-21 Thread Pavel Stehule
čt 21. 2. 2019 v 18:28 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > As mentioned on > > > https://www.cybertec-postgresql.com/en/looking-at-mysql-8-with-postgresql-goggles-on/ > > how about this: > > => \h analyze > Command: ANALYZE > Description: collect statistic