On Fri, May 18, 2018 at 10:22:29AM -0400, Tom Lane wrote:
> Only comment I have is that I think there's similar shortcuts in a lot
> of places :-(
Yeah. A quick lookup is showing me one in xlog.c (XLOG_BLCKSZ) and one
in pg_rewind. (Spotted roughly 392 places to look at in all the core
code). L
On Fri, May 18, 2018 at 4:02 PM, Michael Paquier
wrote:
> On Fri, May 18, 2018 at 03:54:47PM +0300, Heikki Linnakangas wrote:
> > Looks good to me.
>
> +1 for fixing that. get_controlfile() in controldata_utils.c also needs
> to be fixed.
>
Pushed a fix including the controldata_utils.c one.
P
Heikki Linnakangas writes:
> On 18/05/18 14:32, Magnus Hagander wrote:
>> If pg_control is for some reason empty, we give an error messagfe like:
>> 2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
>> file: Success
>> Which is, uh, wrong -- it's definitely not successful.
>
On Fri, May 18, 2018 at 03:54:47PM +0300, Heikki Linnakangas wrote:
> Looks good to me.
+1 for fixing that. get_controlfile() in controldata_utils.c also needs
to be fixed.
--
Michael
signature.asc
Description: PGP signature
On 18/05/18 14:32, Magnus Hagander wrote:
If pg_control is for some reason empty, we give an error messagfe like:
2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
file: Success
Which is, uh, wrong -- it's definitely not successful.
Obviously this is a state where the us
