Heikki Linnakangas <hlinn...@iki.fi> writes: > On 18/05/18 14:32, Magnus Hagander wrote: >> If pg_control is for some reason empty, we give an error messagfe like: >> 2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control >> file: Success >> Which is, uh, wrong -- it's definitely not successful. >> Obviously this is a state where the user is fairly screwed anyway, but we >> should give a better message. >> Attached is a patch that does this. Reasonable?
> Looks good to me. Only comment I have is that I think there's similar shortcuts in a lot of places :-( regards, tom lane