Re: master check fails on Windows Server 2008

2018-02-21 Thread Marina Polyakova
On 21-02-2018 18:51, Tom Lane wrote: Marina Polyakova writes: On 20-02-2018 21:23, Tom Lane wrote: I continue to wonder if it's not better to just remove the option and thereby simplify our lives. What's the actual value of having it anymore? I agree with you, but I have too little experi

Re: master check fails on Windows Server 2008

2018-02-21 Thread Tom Lane
Marina Polyakova writes: > On 20-02-2018 21:23, Tom Lane wrote: >> I continue to wonder if it's not better to just remove >> the option and thereby simplify our lives. What's the actual value of >> having it anymore? > I agree with you, but I have too little experience to vote for removing > th

Re: master check fails on Windows Server 2008

2018-02-21 Thread Marina Polyakova
On 20-02-2018 21:23, Tom Lane wrote: Marina Polyakova writes: On 20-02-2018 3:37, Tom Lane wrote: 4. Try to tweak the stats_ext.sql test conditions in some more refined way to get the test to pass everywhere. This'd be a lot of work with no guarantee of success, so I'm not too excited about

Re: master check fails on Windows Server 2008

2018-02-20 Thread Tom Lane
Marina Polyakova writes: > On 20-02-2018 3:37, Tom Lane wrote: >> 4. Try to tweak the stats_ext.sql test conditions in some more refined >> way to get the test to pass everywhere. This'd be a lot of work with >> no guarantee of success, so I'm not too excited about it. > Thank you for your expla

Re: master check fails on Windows Server 2008

2018-02-20 Thread Marina Polyakova
On 20-02-2018 3:37, Tom Lane wrote: Ah-hah. I can reproduce the described failure if I configure with --disable-float8-byval on an otherwise 64-bit machine. It appears that the minimum work_mem setting that will allow this query to use a hashagg plan on such a configuration is about 155kB (wh

Re: master check fails on Windows Server 2008

2018-02-19 Thread Peter Geoghegan
On Mon, Feb 19, 2018 at 4:37 PM, Tom Lane wrote: > I see several things we could do about this: > > 1. Nothing; just say "sorry, we don't promise that the regression tests > pass with no plan differences on nonstandard configurations". Given that > --disable-float8-byval has hardly any real-world

Re: master check fails on Windows Server 2008

2018-02-19 Thread Tom Lane
Marina Polyakova writes: > On 16-02-2018 19:31, Tom Lane wrote: >> Weird. AFAICS the cost estimates for those two plans should be quite >> different, so this isn't just a matter of the estimates maybe being >> a bit platform-dependent. (And that test has been there nearly a >> year without causi

Re: master check fails on Windows Server 2008

2018-02-17 Thread Marina Polyakova
On 16-02-2018 19:31, Tom Lane wrote: Marina Polyakova writes: Hello, hackers! I got a permanent failure of master (commit 2a41507dab0f293ff241fe8ae326065998668af8) check on Windows Server 2008. Regression output and diffs as well as config.pl are attached. Weird. AFAICS the cost estimates

Re: master check fails on Windows Server 2008

2018-02-16 Thread Tom Lane
Marina Polyakova writes: > Hello, hackers! I got a permanent failure of master (commit > 2a41507dab0f293ff241fe8ae326065998668af8) check on Windows Server 2008. > Regression output and diffs as well as config.pl are attached. Weird. AFAICS the cost estimates for those two plans should be quite