On 27.08.23 14:05, Zhijie Hou (Fujitsu) wrote:
On Friday, August 25, 2023 5:56 PM Amit Kapila wrote:
On Fri, Aug 25, 2023 at 12:38 PM Peter Eisentraut wrote:
On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
On Friday, August 25, 2023 12:28 PM Amit Kapila
wrote:
On Thu, Aug 24, 2023 at 12
On Tuesday, August 29, 2023 3:26 PM Peter Smith wrote:
Thanks for reviewing.
> 2. DebugLogicalRepStreamingMode
>
> -/* possible values for logical_replication_mode */
> +/* possible values for debug_logical_replication_streaming */
> typedef enum
> {
> - LOGICAL_REP_MODE_BUFFERED,
> - LOGICAL
On Tue, Aug 29, 2023 at 12:56 PM Peter Smith wrote:
>
> I had a look at the patch 0001.
>
> It looks OK to me, but here are a couple of comments:
>
> ==
>
> 1. Is this fix intended for PG16?
>
Yes.
> I found some mention of this GUC old name lurking in the release v16 notes
> [1].
>
That s
Hi Hou-san.
I had a look at the patch 0001.
It looks OK to me, but here are a couple of comments:
==
1. Is this fix intended for PG16?
I found some mention of this GUC old name lurking in the release v16 notes [1].
~~~
2. DebugLogicalRepStreamingMode
-/* possible values for logical_repl
On Friday, August 25, 2023 5:56 PM Amit Kapila wrote:
>
> On Fri, Aug 25, 2023 at 12:38 PM Peter Eisentraut
> wrote:
> >
> > On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
> > > On Friday, August 25, 2023 12:28 PM Amit Kapila
> wrote:
> > >>
> > >> On Thu, Aug 24, 2023 at 12:45 PM Peter Eisent
On Fri, Aug 25, 2023 at 12:38 PM Peter Eisentraut wrote:
>
> On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
> > On Friday, August 25, 2023 12:28 PM Amit Kapila
> > wrote:
> >>
> >> On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut
> >> wrote:
> >>>
> >>> I suggest we rename this setting to some
On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote:
On Friday, August 25, 2023 12:28 PM Amit Kapila wrote:
On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut
wrote:
I suggest we rename this setting to something starting with debug_.
Right now, the name looks much too tempting for users to fiddle
On Friday, August 25, 2023 12:28 PM Amit Kapila wrote:
>
> On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut
> wrote:
> >
> > I suggest we rename this setting to something starting with debug_.
> > Right now, the name looks much too tempting for users to fiddle with.
> > I think this is similar
On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut wrote:
>
> I suggest we rename this setting to something starting with debug_.
> Right now, the name looks much too tempting for users to fiddle with. I
> think this is similar to force_parallel_mode.
>
+1. How about debug_logical_replication?
>
