On Wed, Jun 7, 2023 at 11:36 AM Fujii Masao
wrote:
>
>
>
>On 2023/06/07 23:15, Joseph Koshakow wrote:
>> I think I may have discovered a reason why is_superuser is
>> intentionally undocumented. is_superuser is not updated if a role's
>> superuser attribute is changed by another se
On 2023/06/07 23:15, Joseph Koshakow wrote:
I think I may have discovered a reason why is_superuser is
intentionally undocumented. is_superuser is not updated if a role's
superuser attribute is changed by another session. Therefore,
is_superuser may show you an incorrect stale value.
Perhaps
I think I may have discovered a reason why is_superuser is
intentionally undocumented. is_superuser is not updated if a role's
superuser attribute is changed by another session. Therefore,
is_superuser may show you an incorrect stale value.
Perhaps this can be fixed with a show_hook? Otherwise it'
On 2023/04/12 5:41, Joseph Koshakow wrote:
Having said all that I actually think this is the best place for
is_superuser since it doesn't seem to fit in anywhere else.
Yeah, I also could not find more appropriate place for is_superuser than there.
I was implying that I thought it would ha
On Tue, Apr 11, 2023 at 9:37 AM Fujii Masao
wrote:
>> > Yes, this patch moves the descriptions of is_superuser to
config.sgml
>> > and changes its group to PRESET_OPTIONS.
>>
>> is_superuser feels a little out of place in this file. All of
>> the options here apply to the en
On 2023/04/08 23:53, Joseph Koshakow wrote:
On Mon, Apr 3, 2023 at 10:47 AM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote:
> Yes, the patch has not been committed yet because of lack of review
comments.
> Do you have any review comments on this patch?
> Or you think it'
On Sat, Apr 8, 2023 at 10:54 AM Joseph Koshakow wrote:
> is_superuser feels a little out of place in this file. All of
> the options here apply to the entire PostgreSQL server, while
> is_superuser only applies to the current session. The description of
> this file says :
>
> > These options repor
On Mon, Apr 3, 2023 at 10:47 AM Fujii Masao
wrote:
>Yes, the patch has not been committed yet because of lack of review
comments.
>Do you have any review comments on this patch?
>Or you think it's ready for committer?
I'm not very familiar with this code, so I'm not sure how much my
r
On 2023/04/01 22:34, Joseph Koshakow wrote:
The patch updated the guc table for is_superuser in
src/backend/utils/misc/guc_tables.c
Yes, this patch moves the descriptions of is_superuser to config.sgml
and changes its group to PRESET_OPTIONS.
However, when I look at the code on master I do
On Wed, Mar 29, 2023 at 5:21 PM Bruce Momjian wrote:
>
>On Thu, Mar 2, 2023 at 12:00:43PM -0500, Joseph Koshakow wrote:
>>
>>
>> On Thu, Mar 2, 2023 at 11:53 AM Fujii Masao <
masao.fu...@oss.nttdata.com>
>> wrote:
>> >
>> >On 2022/09/14 14:27, bt22kawamotok wrote:
On Thu, Mar 2, 2023 at 12:00:43PM -0500, Joseph Koshakow wrote:
>
>
> On Thu, Mar 2, 2023 at 11:53 AM Fujii Masao
> wrote:
> >
> > On 2022/09/14 14:27, bt22kawamotok wrote:
> > > I update patch to reflect master update.
> >
> > Thanks for updating the patch!
> >
> > +
> >
On Thu, Mar 2, 2023 at 11:53 AM Fujii Masao
wrote:
>
>On 2022/09/14 14:27, bt22kawamotok wrote:
>> I update patch to reflect master update.
>
>Thanks for updating the patch!
>
>+
>+Shows whether the current user is a superuser or not.
>+
>
>How abo
On 2022/09/14 14:27, bt22kawamotok wrote:
I update patch to reflect master update.
Thanks for updating the patch!
+
+Shows whether the current user is a superuser or not.
+
How about adding the note about when this parameter can change,
like we do for in_hot_standby do
Thanks for updating the patch!
The patch looks good to me.
- /* Not for general use --- used by SET SESSION AUTHORIZATION */
{"session_authorization", PGC_USERSET, UNGROUPED,
If we don't document session_authorization and do expect that
it's usually used by SET/SHO
On 2022/09/13 17:25, bt22kawamotok wrote:
Thanks for the patch!
+
+ is_superuser (boolean)
You need to add this entry just after that of "in_hot_standby" because
the descriptions of preset parameters should be placed in alphabetical
order in the docs.
+
+ Reports
Thanks for the patch!
+
+ is_superuser (boolean)
You need to add this entry just after that of "in_hot_standby" because
the descriptions of preset parameters should be placed in alphabetical
order in the docs.
+
+Reports whether the user is superuser or not.
Isn't
On 2022/09/12 17:13, bt22kawamotok wrote:
On the other hand, it seems pretty silly that it's GUC_REPORT if
we want to consider it private. I've not checked the git history,
but I bet that flag was added later with no thought about context.
If we are going to document this then we should at l
On the other hand, it seems pretty silly that it's GUC_REPORT if
we want to consider it private. I've not checked the git history,
but I bet that flag was added later with no thought about context.
If we are going to document this then we should at least remove
the GUC_NO_SHOW_ALL flag and rewri
I wrote:
> On the other hand, it seems pretty silly that it's GUC_REPORT if
> we want to consider it private. I've not checked the git history,
> but I bet that flag was added later with no thought about context.
>
> If we are going to document this then we should at least remove
> the GUC_NO_SHOW
"Euler Taveira" writes:
> On Fri, Sep 9, 2022, at 2:28 AM, bt22kawamotok wrote:
>> is_superuser function checks whether a user is a superuser or not, and
>> is commonly used. However, is_superuser is not documented and is set to
>> UNGROUPED in guc.c. I think is_superuser should be added to the
On Fri, Sep 9, 2022, at 2:28 AM, bt22kawamotok wrote:
> is_superuser function checks whether a user is a superuser or not, and
> is commonly used. However, is_superuser is not documented and is set to
> UNGROUPED in guc.c. I think is_superuser should be added to the
> documentation and set to PR
21 matches
Mail list logo
