Thanks for updating the patch! The patch looks good to me.- /* Not for general use --- used by SET SESSION AUTHORIZATION */ {"session_authorization", PGC_USERSET, UNGROUPED, If we don't document session_authorization and do expect that it's usually used by SET/SHOW SESSION AUTHORIZATION, this comment doesn't need to be removed, I think.
Thanks for reviewing. I update patch to reflect master update.
Could you register this patch into the next Commit Fest so that we don't forget it?
OK. I will register next Commit Fest. Thank you. Regards, Kotaro Kawamoto
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index a5cd4e44c7..6358f5e887 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -10584,6 +10584,19 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir' </listitem> </varlistentry> + <varlistentry id="guc-is-superuser" xreflabel="is_superuser"> + <term><varname>is_superuser</varname> (<type>boolean</type>) + <indexterm> + <primary><varname>is_superuser</varname> configuration parameter</primary> + </indexterm> + </term> + <listitem> + <para> + Shows whether the current user is a superuser or not. + </para> + </listitem> + </varlistentry> + <varlistentry id="guc-lc-collate" xreflabel="lc_collate"> <term><varname>lc_collate</varname> (<type>string</type>) <indexterm> diff --git a/doc/src/sgml/ref/show.sgml b/doc/src/sgml/ref/show.sgml index b3747b119f..d8721be805 100644 --- a/doc/src/sgml/ref/show.sgml +++ b/doc/src/sgml/ref/show.sgml @@ -100,15 +100,6 @@ SHOW ALL </para> </listitem> </varlistentry> - - <varlistentry> - <term><literal>IS_SUPERUSER</literal></term> - <listitem> - <para> - True if the current role has superuser privileges. - </para> - </listitem> - </varlistentry> </variablelist></para> </listitem> </varlistentry> diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 87e625aa7a..6b6e02e162 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -989,11 +989,10 @@ struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - /* Not for general use --- used by SET SESSION AUTHORIZATION */ - {"is_superuser", PGC_INTERNAL, UNGROUPED, + {"is_superuser", PGC_INTERNAL, PRESET_OPTIONS, gettext_noop("Shows whether the current user is a superuser."), NULL, - GUC_REPORT | GUC_NO_SHOW_ALL | GUC_NO_RESET_ALL | GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE + GUC_REPORT | GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE }, &session_auth_is_superuser, false,