Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c

2024-11-06 Thread Daniel Gustafsson
> On 5 Nov 2024, at 22:08, Daniel Gustafsson wrote: > >> On 5 Nov 2024, at 17:40, Fujii Masao wrote: >> >> On 2024/09/24 21:31, Daniel Gustafsson wrote: On 24 Sep 2024, at 10:32, btnakamurakoukil wrote: I noticed unnecessary variable "low" in index_delete_sort() (/postgre

Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c

2024-11-05 Thread Daniel Gustafsson
> On 5 Nov 2024, at 17:40, Fujii Masao wrote: > > On 2024/09/24 21:31, Daniel Gustafsson wrote: >>> On 24 Sep 2024, at 10:32, btnakamurakoukil >>> wrote: >>> I noticed unnecessary variable "low" in index_delete_sort() >>> (/postgres/src/backend/access/heap/heapam.c), patch attached. What do yo

Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c

2024-11-05 Thread Fujii Masao
On 2024/09/24 21:31, Daniel Gustafsson wrote: On 24 Sep 2024, at 10:32, btnakamurakoukil wrote: I noticed unnecessary variable "low" in index_delete_sort() (/postgres/src/backend/access/heap/heapam.c), patch attached. What do you think? That variable does indeed seem to not be used, an

Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c

2024-09-24 Thread Daniel Gustafsson
> On 24 Sep 2024, at 10:32, btnakamurakoukil > wrote: > I noticed unnecessary variable "low" in index_delete_sort() > (/postgres/src/backend/access/heap/heapam.c), patch attached. What do you > think? That variable does indeed seem to not be used, and hasn't been used since it was committed i