On 2024/09/24 21:31, Daniel Gustafsson wrote:
On 24 Sep 2024, at 10:32, btnakamurakoukil <btnakamurakou...@oss.nttdata.com>
wrote:
I noticed unnecessary variable "low" in index_delete_sort()
(/postgres/src/backend/access/heap/heapam.c), patch attached. What do you think?
That variable does indeed seem to not be used, and hasn't been used since it
was committed in d168b666823. The question is if it's a left-over from
development which can be removed, or if it should be set and we're missing an
optimization. Having not read the referenced paper I can't tell so adding
Peter Geoghegan who wrote this for clarification.
It's been about a month without updates. How about removing the unnecessary
variable as suggested? We can always add the "missing" logic later if needed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION