Re: doc examples for pghandler

2020-08-17 Thread Michael Paquier
On Mon, Aug 17, 2020 at 04:30:07PM -0700, Mark Wong wrote: > I've attached a small word diff to suggest a few different words to use > in the README, if that sounds better? Sounds good to me. So applied with those changes. It is really tempting to add an example of validator (one simple thing wo

Re: doc examples for pghandler

2020-08-17 Thread Mark Wong
On Fri, Aug 14, 2020 at 02:25:52PM +0900, Michael Paquier wrote: > On Tue, Aug 11, 2020 at 01:01:10PM -0700, Mark Wong wrote: > > Ah, right. For the moment I've added some empty conditionals for > > trigger and event trigger handling. > > > > I've created a new entry in the commitfest app. [1] I

Re: doc examples for pghandler

2020-08-13 Thread Michael Paquier
On Tue, Aug 11, 2020 at 01:01:10PM -0700, Mark Wong wrote: > Ah, right. For the moment I've added some empty conditionals for > trigger and event trigger handling. > > I've created a new entry in the commitfest app. [1] I'll keep at it. :) Thanks for the patch. I have reviewed and reworked it

Re: doc examples for pghandler

2020-08-11 Thread Mark Wong
On Mon, Jun 15, 2020 at 04:47:01PM +0900, Michael Paquier wrote: > On Sun, Jun 14, 2020 at 08:45:17PM -0700, Mark Wong wrote: > > Sounds good to me. Something more like the attached patch? > > That's the idea. I have not gone in details into what you have here, > but perhaps it would make sense

Re: doc examples for pghandler

2020-06-15 Thread Michael Paquier
On Sun, Jun 14, 2020 at 08:45:17PM -0700, Mark Wong wrote: > Sounds good to me. Something more like the attached patch? That's the idea. I have not gone in details into what you have here, but perhaps it would make sense to do a bit more and show how things are done in the context of a PL functi

Re: doc examples for pghandler

2020-06-14 Thread Mark Wong
On Sat, Jun 13, 2020 at 01:19:17PM +0900, Michael Paquier wrote: > On Fri, Jun 12, 2020 at 10:13:41PM -0400, Tom Lane wrote: > > On second thought, contrib/ is not quite the right place, because we > > typically expect modules there to actually get installed, meaning they > > have to have at least

Re: doc examples for pghandler

2020-06-12 Thread Michael Paquier
On Fri, Jun 12, 2020 at 10:13:41PM -0400, Tom Lane wrote: > On second thought, contrib/ is not quite the right place, because we > typically expect modules there to actually get installed, meaning they > have to have at least some end-user usefulness. The right place for > a toy PL handler is prob

Re: doc examples for pghandler

2020-06-12 Thread Tom Lane
Mark Wong writes: > On Fri, Jun 12, 2020 at 03:10:20PM -0400, Tom Lane wrote: >> I wonder if it'd be possible to adapt what you have here into some >> tiny contrib module that doesn't do very much useful, but can at >> least be tested to see that it compiles; moreover it could be >> copied verbati

Re: doc examples for pghandler

2020-06-12 Thread Mark Wong
On Fri, Jun 12, 2020 at 03:10:20PM -0400, Tom Lane wrote: > Mark Wong writes: > > Would some additional procedure language handler code examples in the > > documentation be good to add? I've put some together in the attached > > patch, and can log it to a future commitfest if people think it woul

Re: doc examples for pghandler

2020-06-12 Thread Tom Lane
Mark Wong writes: > Would some additional procedure language handler code examples in the > documentation be good to add? I've put some together in the attached > patch, and can log it to a future commitfest if people think it would > be a good addition. Hmm. The existing doc examples are reall