Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-04-04 Thread Peter Eisentraut
On 24.03.25 10:24, Jakub Wartak wrote: On Fri, Mar 14, 2025 at 11:31 AM vignesh C wrote: On Wed, 5 Mar 2025 at 11:46, Amit Kapila wrote: On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak I can go with the last patch as you observed that in a real-world case, and we can look at others (if any) on

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-24 Thread Jakub Wartak
On Fri, Mar 14, 2025 at 11:31 AM vignesh C wrote: > > On Wed, 5 Mar 2025 at 11:46, Amit Kapila wrote: > > > > On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak > > > > I can go with the last patch as you observed that in a real-world > > case, and we can look at others (if any) on a case-to-case basis.

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-14 Thread vignesh C
On Wed, 5 Mar 2025 at 11:46, Amit Kapila wrote: > > On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak > > I can go with the last patch as you observed that in a real-world > case, and we can look at others (if any) on a case-to-case basis. > Fujii-San, others, do you have any opinion on this? +1 for th

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-04 Thread Amit Kapila
On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak wrote: > > On Tue, Mar 4, 2025 at 4:59 AM Amit Kapila wrote: > > > > > > > > > Sure thing. I've just added '(..) In the extreme cases this can..' as > > > > it is pretty rare to hit it. Patch attached. > > > > > > When the clock moves forward or backwar

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-04 Thread Jakub Wartak
Hi, On Tue, Mar 4, 2025 at 4:59 AM Amit Kapila wrote: > > > > > > Sure thing. I've just added '(..) In the extreme cases this can..' as > > > it is pretty rare to hit it. Patch attached. > > > > When the clock moves forward or backward, couldn't it affect > > not only the standby but also the pr

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-03 Thread Amit Kapila
On Mon, Mar 3, 2025 at 3:18 PM Fujii Masao wrote: > > On 2025/03/03 16:35, Jakub Wartak wrote: > > Hi Amit, > > > > On Mon, Mar 3, 2025 at 6:26 AM Amit Kapila wrote: > > [..] > > > > OK, sure. > > > >> How about something like: "Note that if the clock on standby is moved > >> ahead or backward, t

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-03 Thread Fujii Masao
On 2025/03/03 16:35, Jakub Wartak wrote: Hi Amit, On Mon, Mar 3, 2025 at 6:26 AM Amit Kapila wrote: [..] OK, sure. How about something like: "Note that if the clock on standby is moved ahead or backward, the feedback message may not be sent at the required interval. This can lead to prolo

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-02 Thread Jakub Wartak
Hi Amit, On Mon, Mar 3, 2025 at 6:26 AM Amit Kapila wrote: [..] OK, sure. > How about something like: "Note that if the clock on standby is moved > ahead or backward, the feedback message may not be sent at the > required interval. This can lead to prolonged risk of not removing > dead rows on

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-03-02 Thread Amit Kapila
On Wed, Jan 8, 2025 at 6:20 PM Jakub Wartak wrote: > > On Wed, Dec 18, 2024 at 10:33 AM Amit Kapila wrote: > > Hi Amit! > > > On Thu, Dec 5, 2024 at 3:14 PM Jakub Wartak > > wrote: > > > > > > One of our customers ran into a very odd case, where hot standby feedback > > > backend_xmin propagati

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2025-01-08 Thread Jakub Wartak
On Wed, Dec 18, 2024 at 10:33 AM Amit Kapila wrote: Hi Amit! > On Thu, Dec 5, 2024 at 3:14 PM Jakub Wartak > wrote: > > > > One of our customers ran into a very odd case, where hot standby feedback > > backend_xmin propagation stopped working due to major (hours/days) clock > > time shifts on

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2024-12-18 Thread Amit Kapila
On Thu, Dec 5, 2024 at 3:14 PM Jakub Wartak wrote: > > One of our customers ran into a very odd case, where hot standby feedback > backend_xmin propagation stopped working due to major (hours/days) clock time > shifts on hypervisor-managed VMs. This happens (and is fully reproducible) > e.g. in

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2024-12-09 Thread Jakub Wartak
Hi Euler!, On Thu, Dec 5, 2024 at 4:07 PM Euler Taveira wrote: > On Thu, Dec 5, 2024, at 6:43 AM, Jakub Wartak wrote: > > One of our customers ran into a very odd case, where hot standby feedback > backend_xmin propagation stopped working due to major (hours/days) clock > time shifts on hypervis

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2024-12-05 Thread Andres Freund
On 2024-12-05 12:06:41 -0300, Euler Taveira wrote: > Is it worth a WARNING message if there is a "huge" time difference > between the servers? We already have the reply time in the message so > it is a matter of defining the "huge" interval plus a roundtrip. We also > need to avoid spamming the log

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

2024-12-05 Thread Euler Taveira
On Thu, Dec 5, 2024, at 6:43 AM, Jakub Wartak wrote: > One of our customers ran into a very odd case, where hot standby feedback > backend_xmin propagation stopped working due to major (hours/days) clock time > shifts on hypervisor-managed VMs. This happens (and is fully reproducible) > e.g. in