On Thu, Jan 28, 2021 at 9:51 PM Masahiko Sawada wrote:
>
> On Sat, Nov 28, 2020 at 5:49 AM Tom Lane wrote:
> >
> > Heikki Linnakangas writes:
> > > Other than that, and a quick pgdindent run, this seems ready to me. I'll
> > > mark it as Ready for Committer.
> >
> > I dunno, this seems largely m
On Sat, Nov 28, 2020 at 5:49 AM Tom Lane wrote:
>
> Heikki Linnakangas writes:
> > Other than that, and a quick pgdindent run, this seems ready to me. I'll
> > mark it as Ready for Committer.
>
> I dunno, this seems largely misguided to me.
>
> It's already the case that index correlation is just
Heikki Linnakangas writes:
> Other than that, and a quick pgdindent run, this seems ready to me. I'll
> mark it as Ready for Committer.
I dunno, this seems largely misguided to me.
It's already the case that index correlation is just not the right
stat for this purpose, since it doesn't give yo
On 06/11/2020 19:57, Justin Pryzby wrote:
On Fri, Nov 06, 2020 at 01:51:26PM +, Anastasia Lubennikova wrote:
The first patch is simply a refactoring and don't see any possible objections
against it.
The second patch also looks fine to me. The logic is understandable and the
code is neat.
On Fri, Nov 06, 2020 at 01:51:26PM +, Anastasia Lubennikova wrote:
> I wonder why this patch hangs so long without a review. Maybe it will help to
> move discussion forward, if you provide more examples of queries that can
> benefit from this imporovement?
Thanks for looking.
The explanatio
Status update for a commitfest entry
According to cfbot, the patch fails to apply. Could you please send a rebased
version?
I wonder why this patch hangs so long without a review. Maybe it will help to
move discussion forward, if you provide more examples of queries that can
benefit from this
There were no comments last month, so rebased, fixed tests, and kicked to next
CF.
--
Justin
>From e754a93aff10cb435f5ecef923a810b9edc02d68 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Wed, 8 Jan 2020 19:23:51 -0600
Subject: [PATCH v5 1/2] Make more clear the computation of min/max IO..
.
On Mon, Jan 06, 2020 at 11:26:06PM -0600, Justin Pryzby wrote:
> As Jeff has pointed out, high correlation has two effects in cost_index():
> 1) the number of pages read will be less;
> 2) the pages will be read more sequentially;
>
> cost_index reuses the pages_fetched variable, so (1) isn't part
On Tue, Jan 07, 2020 at 09:21:03AM +0530, Dilip Kumar wrote:
> On Tue, Jan 7, 2020 at 1:29 AM Justin Pryzby wrote:
> >
> > Find attached cleaned up patch.
> > For now, I updated the regress/expected/, but I think the test maybe has to
> > be
> > updated to do what it was written to do.
>
> I hav
On Tue, Jan 7, 2020 at 1:29 AM Justin Pryzby wrote:
>
> Find attached cleaned up patch.
> For now, I updated the regress/expected/, but I think the test maybe has to be
> updated to do what it was written to do.
I have noticed that in "cost_index" we have used the indexCorrelation
for computing t
Find attached cleaned up patch.
For now, I updated the regress/expected/, but I think the test maybe has to be
updated to do what it was written to do.
>From 36f547d69b8fee25869d6ef3ef26d327a8ba1205 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 1 Jan 2019 16:17:28 -0600
Subject: [PATCH v
On Sun, Dec 01, 2019 at 12:34:37PM +0900, Michael Paquier wrote:
> On Sat, Nov 02, 2019 at 03:26:17PM -0500, Justin Pryzby wrote:
> > Attached is a fixed and rebasified patch for cfbot.
> > Included inline for conceptual review.
>
> Your patch still causes two regression tests to fail per Mr Robot
On Sat, Nov 02, 2019 at 03:26:17PM -0500, Justin Pryzby wrote:
> Attached is a fixed and rebasified patch for cfbot.
> Included inline for conceptual review.
Your patch still causes two regression tests to fail per Mr Robot's
report: join and select. Could you look at those problems? I have
move
Attached is a fixed and rebasified patch for cfbot.
Included inline for conceptual review.
>From f3055a5696924427dda280da702c41d2d2796a24 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 1 Jan 2019 16:17:28 -0600
Subject: [PATCH v2] Use correlation statistic in costing bitmap scans..
Sam
Attached for real.
diff --git a/src/backend/optimizer/path/costsize.c b/src/backend/optimizer/path/costsize.c
index 88780c0..1c25f36 100644
--- a/src/backend/optimizer/path/costsize.c
+++ b/src/backend/optimizer/path/costsize.c
@@ -548,11 +548,12 @@ cost_index(IndexPath *path, PlannerInfo *root, do
15 matches
Mail list logo
