Re: additional foreign key test coverage

2019-01-16 Thread Peter Eisentraut
On 09/01/2019 09:20, Mi Tar wrote: > I tested this patch and it applied cleanly and all tests passed. I haven't > looked if the changes to tests are reasonable or extensive to cover all > aspects of what they want to cover. I have committed this with additional tests for partitioned tables, as r

Re: additional foreign key test coverage

2019-01-09 Thread Mi Tar
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi! I tested this patch and it applied cleanly and all tests passed. I h

Re: additional foreign key test coverage

2018-12-07 Thread Alvaro Herrera
On 2018-Dec-07, Peter Eisentraut wrote: > On 04/12/2018 14:23, Alvaro Herrera wrote: > > Hmm. One of the things I did for FKs on partitioned tables was remove > > all the cases involving only unpartitioned tables, then run just the > > foreign_key test and see what the coverage looked like -- in

Re: additional foreign key test coverage

2018-12-07 Thread Peter Eisentraut
On 04/12/2018 14:23, Alvaro Herrera wrote: > On 2018-Dec-04, Peter Eisentraut wrote: > >> During the development of my recent patch "unused/redundant foreign key >> code" [0], I had developed a few additional test cases to increase the >> coverage in ri_triggers.c. They are in the attached patche

Re: additional foreign key test coverage

2018-12-04 Thread Alvaro Herrera
On 2018-Dec-04, Peter Eisentraut wrote: > During the development of my recent patch "unused/redundant foreign key > code" [0], I had developed a few additional test cases to increase the > coverage in ri_triggers.c. They are in the attached patches with > explanations. With these, coverage shoul