Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

2024-12-09 Thread Michael Paquier
On Sat, Sep 14, 2024 at 06:57:21PM +, Akshat Jaimini wrote: > Quick question, are there any more revisions left to be done on this > patch from the previous feedback? This patch is still listed in the CF app waiting on author with what looks like Robert and Tom objecting to it, because it mak

Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

2024-09-14 Thread Akshat Jaimini
Hi, Quick question, are there any more revisions left to be done on this patch from the previous feedback? Or should I continue with reviewing the current patch? Regards, Akshat Jaimini

Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

2024-05-13 Thread Robert Haas
On Mon, May 13, 2024 at 10:53 AM Matthias van de Meent wrote: > It's not inconceivable that this will significantly increase WAL > volume, but I think we should go for correctness rather than fastest > copy. I don't think we can afford to just do this blindly for the sake of a hypothetical non-co

Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

2024-05-13 Thread Matthias van de Meent
On Mon, 13 May 2024 at 16:13, Tom Lane wrote: > > Matthias van de Meent writes: > > PFA a patch that fixes this issue, by assuming that all pages in the > > source database utilize a non-standard page layout. > > Surely that cure is worse than the disease? I don't know where we would get the inf

Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

2024-05-13 Thread Tom Lane
Matthias van de Meent writes: > PFA a patch that fixes this issue, by assuming that all pages in the > source database utilize a non-standard page layout. Surely that cure is worse than the disease? regards, tom lane