Re: Use pg_pwrite() in pg_test_fsync

2021-02-14 Thread Thomas Munro
On Sun, Jan 24, 2021 at 1:50 PM Thomas Munro wrote: > On Sun, Jan 10, 2021 at 9:21 AM Thomas Munro wrote: > > I left the fsync-after-closing and non-sync'd tests using write(), > > because they weren't using lseek(). The latter case is arguably a bit > > odd because it's not overwriting pre-allo

Re: Use pg_pwrite() in pg_test_fsync

2021-01-23 Thread Thomas Munro
On Sun, Jan 10, 2021 at 9:21 AM Thomas Munro wrote: > I left the fsync-after-closing and non-sync'd tests using write(), > because they weren't using lseek(). The latter case is arguably a bit > odd because it's not overwriting pre-allocated blocks, unlike the > earlier tests. On closer inspecti